1599114 - StrongOrRawPtr should accept a RefPtr

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect)

Description

[Simon Giesecke [:sg] [he/him]]

StrongOrRawPtr only accepts a raw pointer or the deprecated already_AddRefed<>&&. It should also accept RefPtr<>&& directly to not force classes implementing the binding to use already_AddRefed.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1599114 - Allow StrongOrRawPtr to accept RefPtr. r=bzbarsky

Comment 2

[Boris Zbarsky [:bzbarsky]]

The patch is fine as far as it goes, bug could you point me to where already_AddRefed got deprecated? The last discussion I see on that is in 2016 (on mozilla.dev.platform), and the conclusion seemed to be that using RefPtr by value in places where we currently use already_AddRefed lost us valuable assertions about expected behavior and introduced threadsafety concerns. Has something changed since then?

Comment 3

[Simon Giesecke [:sg] [he/him]]

I was following https://bugzilla.mozilla.org/show_bug.cgi?id=1349379. It's what the summary of the bug says. In conclusion, maybe "deprecated" does not properly describe this, but "deprecated except for specific uses that remain legitimate" is what I understand from that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Ah, I see. The summary there doesn't really cover the situation, yeah.

Returning RefPtr is slightly footgunny right now, but I guess for the specific cases where StrongOrRawPtr is used it's not really a problem. We just need to watch out for people overusing RefPtr return values where they're not really needed or appropriate...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0b2e7b06070
Allow StrongOrRawPtr to accept RefPtr. r=bzbarsky

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a0b2e7b06070