1599136 - Crash in [@ cubeb_backend::capi::capi_stream_stop]

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-13c51c5c-fc89-4bd4-89f2-b6b3d0191112.

Seen while looking at macOS specific crashes: https://bit.ly/33fToSU. First crashes in 72 seen in 20191022094606, but there also a few crashes when nightly was in 71. URLs seem to be either youtube or netflix.

Crashes all have Moz Crash reason: assertion failed: stop_audiounit(self.output_unit).is_ok()

Top 10 frames of crashing thread:

0 XUL gkrust_shared::panic_hook mfbt/Assertions.h:332
1 XUL core::ops::function::Fn::call src/libcore/ops/function.rs:69
2 XUL std::panicking::rust_panic_with_hook src/libstd/panicking.rs:481
3 XUL std::panicking::begin_panic src/libstd/panicking.rs:411
4 XUL cubeb_backend::capi::capi_stream_stop third_party/rust/cubeb-backend/src/capi.rs:186
5 XUL mozilla::AudioStream::Shutdown dom/media/AudioStream.cpp:412
6 XUL mozilla::AudioSinkWrapper::Stop dom/media/mediasink/AudioSinkWrapper.cpp:199
7 XUL mozilla::VideoSink::Stop dom/media/mediasink/VideoSink.cpp:330
8 XUL mozilla::MediaDecoderStateMachine::StopMediaSink dom/media/MediaDecoderStateMachine.cpp:3059
9 XUL mozilla::MediaDecoderStateMachine::AccurateSeekingState::DoSeek dom/media/MediaDecoderStateMachine.cpp:1157

Comment 1

[C.M.Chang[:chunmin]]

Some crash-reports in bug 1595457 give a similar crash reason like this. I suspect stream-stop might be run at the same time when the stream is reinitialized or destroyed. I will solve those racing issues in bug 1598413 and see if it could also fix this problem.

Comment 2

[Paul Adenot (:padenot)]

Chun-Min, would you mind checking if we can close this, or if there is still something to do?

Comment 3

[C.M.Chang[:chunmin]]

I am monitoring its crash rate after landing bug 1598413. For now, there is no crash report after 20191213 build. I would like to wait one more week to see if the crash happens again. If there is no more reports, then we can close this bug.

Comment 4

[C.M.Chang[:chunmin]]

No report after landing bug 1598413. I am going to mark this solved.