Watchpoints - After click Refresh option JS execution cannot pause anymore
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(firefox-esr68 unaffected, firefox71 unaffected, firefox72 verified, firefox73 verified)
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox71 | --- | unaffected |
firefox72 | --- | verified |
firefox73 | --- | verified |
People
(Reporter: marcela.calderon, Assigned: jlast)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
2.30 MB,
video/mp4
|
Details | |
2.38 MB,
video/mp4
|
Details | |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
After watchpoint property set is created, if the user click on Refresh button, JS execution stop working
Affected versions
Firefox versions Nightly 72.0a1
Affected platforms
Windows 10
Steps to reproduce
- Launch the RTL Firefox Browser and open http://janodvarko.cz/tests/debugger/watchpoints/
- Open Developer Tools and click on "Click Me!" button in Test Case #!
- On Scopes Side Panel looks for object and add watchpoint (property set or get)
- Click on refresh button
- Click on "Click Me!" button
Actual Result
JS cannot pause anymore. It seems like the watchpoint has not been removed (See attachment "Refresh_Not_works_1.mp4")
Note
If the user first click on "Resume" button, after click Refresh option, "Click Me!" works ok and JS execution is paused.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Confirming that I can easily reproduce the issue on my machine (Win10, Fx Nightly)
Reopening the Toolbox is not enough to fix the issue (the Debugger doesn't properly updates its UI when pausing JS execution).
I had to restart Firefox to be able to properly pause JS execution again.
Honza
Assignee | ||
Comment 4•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 7•5 years ago
|
||
bugherder |
Reporter | ||
Comment 8•5 years ago
|
||
Verified fixed on lates Nightly Version 73.0a1 Build ID 20191208213628 on Windows 10, macOS 10.14 and Ubuntu 18.04
Assignee | ||
Comment 9•5 years ago
|
||
Comment on attachment 9113892 [details]
Bug 1599177 - Watchpoints - After click Refresh option JS execution cannot pause anymore. r=jaril
Beta/Release Uplift Approval Request
- User impact if declined: Watchpoints (new debugger feature) will stop working if the user refreshes the page while paused because of a watchpoint.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): it only affects the debugger.
- String changes made/needed:
Comment 10•5 years ago
|
||
Comment on attachment 9113892 [details]
Bug 1599177 - Watchpoints - After click Refresh option JS execution cannot pause anymore. r=jaril
debugger fix, approved for 72.0b5
Updated•5 years ago
|
Comment 11•5 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 12•5 years ago
|
||
Verified fixed on Beta Version 72.0b5 Build ID 20191210230245 on Windows 10, macOS 10.14 and Ubuntu 18.04
Description
•