1599177 - Watchpoints - After click Refresh option JS execution cannot pause anymore

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Marcela (Please NI request to Brindusa Tot)]

Attachment: Refresh_Not_works.mp4

After watchpoint property set is created, if the user click on Refresh button, JS execution stop working

Affected versions
Firefox versions Nightly 72.0a1

Affected platforms
Windows 10

Steps to reproduce

1. Launch the RTL Firefox Browser and open http://janodvarko.cz/tests/debugger/watchpoints/
2. Open Developer Tools and click on "Click Me!" button in Test Case #!
3. On Scopes Side Panel looks for object and add watchpoint (property set or get)
4. Click on refresh button
5. Click on "Click Me!" button

Actual Result
JS cannot pause anymore. It seems like the watchpoint has not been removed (See attachment "Refresh_Not_works_1.mp4")

Note
If the user first click on "Resume" button, after click Refresh option, "Click Me!" works ok and JS execution is paused.

Comment 1

[Marcela (Please NI request to Brindusa Tot)]

Attachment: Refresh_Not_works_1.mp4

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Confirming that I can easily reproduce the issue on my machine (Win10, Fx Nightly)

Reopening the Toolbox is not enough to fix the issue (the Debugger doesn't properly updates its UI when pausing JS execution).
I had to restart Firefox to be able to properly pause JS execution again.

Honza

Comment 4

[Jason Laster [:jlast]]

Attachment: Bug 1599177 - Watchpoints - After click Refresh option JS execution cannot pause anymore. r=jaril

Comment 5

[jaril]

Attachment: Bug 1599177 - Remove watchpoints properly on navigate r=jlast

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10160518ddc8
Watchpoints -  After click Refresh option JS execution cannot pause anymore. r=bhackett

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/10160518ddc8

Comment 8

[Marcela (Please NI request to Brindusa Tot)]

Verified fixed on lates Nightly Version 73.0a1 Build ID 20191208213628 on Windows 10, macOS 10.14 and Ubuntu 18.04

Comment 9

[Jason Laster [:jlast]]

Comment on attachment 9113892 [details]
Bug 1599177 - Watchpoints - After click Refresh option JS execution cannot pause anymore. r=jaril

Beta/Release Uplift Approval Request

• User impact if declined: Watchpoints (new debugger feature) will stop working if the user refreshes the page while paused because of a watchpoint.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): it only affects the debugger.
• String changes made/needed:

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9113892 [details]
Bug 1599177 - Watchpoints - After click Refresh option JS execution cannot pause anymore. r=jaril

debugger fix, approved for 72.0b5

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac6e049005c4

Comment 12

[Marcela (Please NI request to Brindusa Tot)]

Verified fixed on Beta Version 72.0b5 Build ID 20191210230245 on Windows 10, macOS 10.14 and Ubuntu 18.04