1599214 - https://wattenberger.com/guide/scaling-svg has bad blob behaviour because of nsSVGPatternFrame::PaintPattern

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

https://perfht.ml/2qAozet

Comment 1

[Jessie [:jbonisteel] pls NI]

Can you take a look and let us know what you think is up with this?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Here's a stack for CreateSimilarDrawTarget where we make a (width = 8983, height = 8983) surface:

frame #0: 0x00000001104f67d8 XUL`mozilla::gfx::DrawTargetRecording::CreateSimilarDrawTarget(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::SurfaceFormat) const [inlined] RefPtr<mozilla::gfx::DrawTarget>::RefPtr(this=<unavailable>) at RefPtr.h:88:9 [opt]
    frame #1: 0x00000001104f67d8 XUL`mozilla::gfx::DrawTargetRecording::CreateSimilarDrawTarget(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::SurfaceFormat) const [inlined] RefPtr<mozilla::gfx::DrawTarget>::RefPtr(this=<unavailable>) at RefPtr.h:90 [opt]
    frame #2: 0x00000001104f67d8 XUL`mozilla::gfx::DrawTargetRecording::CreateSimilarDrawTarget(this=0x00007f824fd9ca90, aSize=0x00007ffee5bdc510, aFormat=B8G8R8A8) const at DrawTargetRecording.cpp:536 [opt]
    frame #3: 0x000000011256af21 XUL`nsSVGPatternFrame::PaintPattern(this=<unavailable>, aDrawTarget=0x00007f824fd9ca90, patternMatrix=0x00007ffee5bdc610, aContextMatrix=0x40c18b5560000000, aSource=0x00007f82f9a96ca0, aFillOrStroke=00 00 00 00 00 00 00 00, aGraphicOpacity=1, aOverrideBounds=None, None, None, None, aImgParams=0x00007ffee5bdc9b0) at nsSVGPatternFrame.cpp:329:40 [opt]
    frame #4: 0x000000011256c4a9 XUL`nsSVGPatternFrame::GetPaintServerPattern(this=<unavailable>, aSource=<unavailable>, aDrawTarget=<unavailable>, aContextMatrix=<unavailable>, aFillOrStroke=<unavailable>, aGraphicOpacity=<unavailable>, aImgParams=<unavailable>, aOverrideBounds=None, None, None, None) at nsSVGPatternFrame.cpp:684:7 [opt]
  * frame #5: 0x000000011257404b XUL`nsSVGUtils::MakeFillPatternFor(aFrame=0x00007f82f9a96ca0, aContext=0x00007f824fd9cb50, aOutPattern=<unavailable>, aImgParams=0x00007ffee5bdc9b0, aContextPaint=<unavailable>) at nsSVGUtils.cpp:1384:13 [opt]
    frame #6: 0x000000011253659f XUL`mozilla::SVGGeometryFrame::Render(this=<unavailable>, aContext=0x00007f824fd9cb50, aRenderComponents=3, aTransform=0x0000000000000000, aImgParams=0x00007ffee5bdc9b0) at SVGGeometryFrame.cpp:699:5 [opt]
    frame #7: 0x0000000112536250 XUL`mozilla::SVGGeometryFrame::PaintSVG(this=0x00007f82f9a96ca0, aContext=0x00007f824fd9cb50, aTransform=0x00007ffee5bdc980, aImgParams=0x00007ffee5bdc9b0, aDirtyRect=<unavailable>) at SVGGeometryFrame.cpp:264:5 [opt]
    frame #8: 0x0000000112535a68 XUL`nsDisplaySVGGeometry::Paint(this=0x00007f82f9ab6198, aBuilder=<unavailable>, aCtx=<unavailable>) at SVGGeometryFrame.cpp:120:43 [opt]
    frame #9: 0x0000000110682e62 XUL`mozilla::layers::DIGroup::PaintItemRange(this=0x00007f824fd9c348, aGrouper=0x00007ffee5bdcff8, aStartItem=0x00007f82f9ab6198, aEndItem=0x0000000000000000, aContext=0x00007f824fd9cb50, aRecorder=0x00007f824fd9c640, aRootManager=0x00007f8308081148, aResources=0x00007ffee5bde788) at WebRenderCommandBuilder.cpp:824:26 [opt]

Replaying this for every tile is obviously problematic.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

If we can convert this CreateSimilarDrawTarget to a CreateClippedDrawTarget that should solve the problem. I'm not sure how easy that will be to do.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Standalone version

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 1599214 - Make CreateClippedDrawTarget const. r=jrmuizel

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 1599214 - Use CreateClippedDrawTarget in nsSVGPatternFrame::PaintPattern. r=jrmuizel

Depends on D58937

Comment 7

[Nicolas Silva [:nical]]

Jeff already did the investigation, let's see if naively replacing with ClippedDrawTarget works out (looked OK at a glance on a debug build).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cc4e49e332bdb2e90a2e984449a9dc8ac576e0e

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Looks like not.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

CreateClippedDrawTarget is only usable as a more sophisticated version of PushLayer. It assumes that it is painted at 1-1 device scale without tiling. I wouldn't be surprised if these assumptions do not hold for PaintPattern.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jrmuizel, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

This works fine now because of bug 1617493