Closed Bug 1599258 Opened 3 months ago Closed 3 months ago

Some dialog buttons lost their correct location

Categories

(Firefox :: Preferences, defect, P1, major)

defect

Tracking

()

VERIFIED FIXED
Firefox 73
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- unaffected
firefox72 blocking verified
firefox73 --- verified

People

(Reporter: itiel_yn8, Assigned: bytesized)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files)

Attached image Before

See before vs. after.

Attached image After
Attached image Screenshot

Also see the buttons are now mixed up with textboxes in the saved addresses dialog.

Kirk, can you take a look please?

Flags: needinfo?(ksteuber)

Yeah, I think I will probably be able to fix this pretty quickly.

Assignee: nobody → ksteuber
Flags: needinfo?(ksteuber)
Priority: -- → P1

Quick update: I have a fix that seems to work for the issue illustrated in Comment 2. Unfortunately, it does not seem to address the issues seen in the description and in comment 1. Hopefully I can figure those out tomorrow.

Duplicate of this bug: 1599797

[Tracking Requested - why for this release]:
User-visible UI regression that we shouldn't ship.

(In reply to Kirk Steuber (he/him) [:bytesized] from comment #5)

Quick update: I have a fix that seems to work for the issue illustrated in Comment 2. Unfortunately, it does not seem to address the issues seen in the description and in comment 1. Hopefully I can figure those out tomorrow.

Comment 1 is a separate problem - that's Bug 1600281 (which I'm working on a fix for).

See Also: → 1600281

Ah, great. I'll just post the fix I have then.

Pushed by shindli@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/33a6c9b06a02
Ensure that unexpected body elements don't end up with display:-moz-box r=Gijs
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
Flags: qe-verify+

Reproduced the initial issue using an old Nightly build: 20191125095200.
Verified - fixed on latest Nightly 73.0a1 (2019-12-03) (Build id: 20191203094830) on Mac OS 10.14 , Windows 10 and Ubuntu 18.04

Comment on attachment 9113004 [details]
Bug 1599258 - Ensure that unexpected body elements don't end up with display:-moz-box r=Gijs

Beta/Release Uplift Approval Request

  • User impact if declined: Misaligned buttons in form autofill dialog: Attachment 9111391 [details]
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Straightforward CSS fix
  • String changes made/needed: no
Attachment #9113004 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

Comment on attachment 9113004 [details]
Bug 1599258 - Ensure that unexpected body elements don't end up with display:-moz-box r=Gijs

simple fix for a new regression, approved for 72.0b3

Attachment #9113004 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified - fixed on latest Beta 72.0b3 (2019-12-04) (Build id: 20191204104712) on Mac OS 10.14 , Windows 10 and Ubuntu 18.04

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.