1599258 - Some dialog buttons lost their correct location

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Itiel]

Attachment: Before

See before vs. after.

Comment 1

[Itiel]

Attachment: After

Comment 2

[Itiel]

Attachment: Screenshot

Also see the buttons are now mixed up with textboxes in the saved addresses dialog.

Comment 3

[:Gijs (out for now; he/him)]

Kirk, can you take a look please?

Comment 4

[Robin Steuber (she/her) [:bytesized]]

Yeah, I think I will probably be able to fix this pretty quickly.

Comment 5

[Robin Steuber (she/her) [:bytesized]]

Quick update: I have a fix that seems to work for the issue illustrated in Comment 2. Unfortunately, it does not seem to address the issues seen in the description and in comment 1. Hopefully I can figure those out tomorrow.

Comment 7

[:Gijs (out for now; he/him)]

[Tracking Requested - why for this release]:
User-visible UI regression that we shouldn't ship.

Comment 8

[Brian Grinstead [:bgrins]]

(In reply to Kirk Steuber (he/him) [:bytesized] from comment #5)

Quick update: I have a fix that seems to work for the issue illustrated in Comment 2. Unfortunately, it does not seem to address the issues seen in the description and in comment 1. Hopefully I can figure those out tomorrow.

Comment 1 is a separate problem - that's Bug 1600281 (which I'm working on a fix for).

Comment 9

[Robin Steuber (she/her) [:bytesized]]

Ah, great. I'll just post the fix I have then.

Comment 10

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1599258 - Ensure that unexpected body elements don't end up with display:-moz-box r=Gijs

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/33a6c9b06a02
Ensure that unexpected body elements don't end up with display:-moz-box r=Gijs

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/33a6c9b06a02

Comment 13

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly build: 20191125095200.
Verified - fixed on latest Nightly 73.0a1 (2019-12-03) (Build id: 20191203094830) on Mac OS 10.14 , Windows 10 and Ubuntu 18.04

Comment 14

[Tim Nguyen :ntim]

Comment on attachment 9113004 [details]
Bug 1599258 - Ensure that unexpected body elements don't end up with display:-moz-box r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Misaligned buttons in form autofill dialog: Attachment 9111391 [details]
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Straightforward CSS fix
• String changes made/needed: no

Comment 15

[Julien Cristau [:jcristau]]

Comment on attachment 9113004 [details]
Bug 1599258 - Ensure that unexpected body elements don't end up with display:-moz-box r=Gijs

simple fix for a new regression, approved for 72.0b3

Comment 16

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee5eb4cfe641

Comment 17

[Alin Ilea, Desktop Test Engineering]

Verified - fixed on latest Beta 72.0b3 (2019-12-04) (Build id: 20191204104712) on Mac OS 10.14 , Windows 10 and Ubuntu 18.04

Comment 18

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.