1599260 - Add support for "loaderId" to "Page.lifecycleEvent"

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

The Page.lifecycleEvent needs the loaderId property set. But as long as we don't have that value from the Page.navigate command, there is nothing we can do here.

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Bug 1599257 adds the plumbing for loaderId but does not return it. This is because client navigation methods (e.g. Page.goto in Puppeteer) break unless the loader id returned by Page.navigate matches the one in life cycle events.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Maja, do you want to work on that next once bug 1599257 has been fixed? I feel this should have been on the reserved list for the next milestone. I assume it affects a lot of tests?

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1599260 - Include loader id in Page.lifecycleEvent

Depends on D74579

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1599260 - [puppeteer] Check for favicon in request/response test

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4f9dcd527b9
Include loader id in Page.lifecycleEvent r=remote-protocol-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/12e3a7252e68
[puppeteer] Check for favicon in request/response test r=remote-protocol-reviewers,whimboo

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d4f9dcd527b9
https://hg.mozilla.org/mozilla-central/rev/12e3a7252e68