Fix antitracking browser_subResources.js tests for Fission
Categories
(Core :: Privacy: Anti-Tracking, task, P1)
Tracking
()
People
(Reporter: cpeterson, Assigned: timhuang)
References
Details
Kasahv, some anti-tracking tests you fixed and unskipped for Fission in bug 1578465 were later (inadvertently?) re-skipped by bug 1596832:
https://hg.mozilla.org/mozilla-central/rev/38d6fbdbee75e8ba0ac046dbffa1d3b07c254792
[browser_subResources.js]
[browser_subResourcesPartitioned.js]
[browser_storageAccessRemovalNavigateSubframe.js]
[browser_storageAccessRemovalNavigateTopframe.js]
[browser_storageAccessSandboxed.js]
Reporter | ||
Updated•4 years ago
|
Comment 1•4 years ago
|
||
(In reply to Chris Peterson [:cpeterson] from comment #0)
Kasahv, some anti-tracking tests you fixed and unskipped for Fission in bug 1578465 were later (inadvertently?) re-skipped by bug 1596832:
FWIW those tests were already disabled on Fission before that bug, even though the annotations don't immediately make you believe so, see the second paragraph of this comment. As far as fission is concerned, bug 1596832 didn't enable or disable any new tests...
Comment 2•4 years ago
|
||
(BTW this means all of these tests are disabled on Fission. I wonder if the Fission team is keeping track of these tests...)
Reporter | ||
Comment 3•4 years ago
•
|
||
(In reply to :ehsan akhgari from comment #1)
FWIW those tests were already disabled on Fission before that bug, even though the annotations don't immediately make you believe so, see the second paragraph of this comment. As far as fission is concerned, bug 1596832 didn't enable or disable any new tests...
Thanks for the correction. In that case, we can use this bug to fix the browser_subResources.js tests (and not just re-enable them).
(In reply to :ehsan akhgari from comment #2)
(BTW this means all of these tests are disabled on Fission. I wonder if the Fission team is keeping track of these tests...)
@ kmag: should we be testing Fission with serviceworker_e10s enabled? I don't see any of the mochitests skipped for skip-if=serviceworker_e10s
in our Fission mochitest spreadsheet:
Comment 4•4 years ago
|
||
Fission's DocumentChannel work requires serviceworker_e10s pref. The serviceworker_e10s pref is enabled by default on Nightly and Fission is also held only in Nightly for now, so we are always testing with it enabled.
Our spreadsheet is intentionally tracking only those tests that are skipped or failed with fission, and no other combinations. The expectation is for the component owners to make the tests work with fission also when they fix them for the SW_e10s configuration, so we don't increase the M-fis count.
Since enabling these tests will depend on making the anti-tracking backend Fission-compatible, I'm moving this to M6.
Updated•4 years ago
|
Updated•4 years ago
|
Comment 5•4 years ago
|
||
tim, assigned to you because I think this is related to what you're working on.
Assignee | ||
Comment 6•4 years ago
|
||
The tests are supposed to be able to test in Fission after bug 1633340.
Reporter | ||
Comment 7•4 years ago
|
||
Clearing Fission Milestone for bugs resolved as duplicates. We don't need to track duplicates.
Description
•