Open Bug 1599278 Opened 4 months ago Updated 3 months ago

Fix antitracking browser_subResources.js tests for Fission

Categories

(Core :: Privacy: Anti-Tracking, task, P2)

task

Tracking

()

Fission Milestone M6

People

(Reporter: cpeterson, Unassigned)

References

(Depends on 1 open bug)

Details

Kasahv, some anti-tracking tests you fixed and unskipped for Fission in bug 1578465 were later (inadvertently?) re-skipped by bug 1596832:

https://hg.mozilla.org/mozilla-central/rev/38d6fbdbee75e8ba0ac046dbffa1d3b07c254792

[browser_subResources.js]
[browser_subResourcesPartitioned.js]
[browser_storageAccessRemovalNavigateSubframe.js]
[browser_storageAccessRemovalNavigateTopframe.js]
[browser_storageAccessSandboxed.js]

Flags: needinfo?(kmadan)
Fission Milestone: --- → M4.1

(In reply to Chris Peterson [:cpeterson] from comment #0)

Kasahv, some anti-tracking tests you fixed and unskipped for Fission in bug 1578465 were later (inadvertently?) re-skipped by bug 1596832:

FWIW those tests were already disabled on Fission before that bug, even though the annotations don't immediately make you believe so, see the second paragraph of this comment. As far as fission is concerned, bug 1596832 didn't enable or disable any new tests...

(BTW this means all of these tests are disabled on Fission. I wonder if the Fission team is keeping track of these tests...)

(In reply to :ehsan akhgari from comment #1)

FWIW those tests were already disabled on Fission before that bug, even though the annotations don't immediately make you believe so, see the second paragraph of this comment. As far as fission is concerned, bug 1596832 didn't enable or disable any new tests...

Thanks for the correction. In that case, we can use this bug to fix the browser_subResources.js tests (and not just re-enable them).

(In reply to :ehsan akhgari from comment #2)

(BTW this means all of these tests are disabled on Fission. I wonder if the Fission team is keeping track of these tests...)

@ kmag: should we be testing Fission with serviceworker_e10s enabled? I don't see any of the mochitests skipped for skip-if=serviceworker_e10s in our Fission mochitest spreadsheet:

https://docs.google.com/spreadsheets/d/1kjp32JTuB4axM3wKx0iIYL2Ado-HcyeBhoY-siGxYAs/edit#gid=1560718888

Flags: needinfo?(kmadan) → needinfo?(kmaglione+bmo)
Summary: Re-enable antitracking browser_subResources.js tests for Fission → Fix antitracking browser_subResources.js tests for Fission

Fission's DocumentChannel work requires serviceworker_e10s pref. The serviceworker_e10s pref is enabled by default on Nightly and Fission is also held only in Nightly for now, so we are always testing with it enabled.

Our spreadsheet is intentionally tracking only those tests that are skipped or failed with fission, and no other combinations. The expectation is for the component owners to make the tests work with fission also when they fix them for the SW_e10s configuration, so we don't increase the M-fis count.

Since enabling these tests will depend on making the anti-tracking backend Fission-compatible, I'm moving this to M6.

Fission Milestone: M4.1 → M6
Depends on: etp-fission
Flags: needinfo?(kmaglione+bmo)
Component: DOM: Content Processes → Privacy: Anti-Tracking
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.