159929 - Info.plist file lacking important capability info for Mac OS X 10.2

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Steve Dagley]

The current info.plist file for Mozilla does not contain a CFBundleURLTypes
entry.  Without such an entry specifying we can handle URLs of type http & https
we will not show up as a choice for default browser in the Internet prefs pane
in System Preferences under Mac OS X 10.2.

Our CFBundleDocumentTypes entry also incorrectly lists .html and .htm files as
text files rather than HTML Documents.

Comment 1

[Steve Dagley]

Attachment: Revised source for Mozilla plist

Since the @#$^& file in the repository is checked in -kb I can't diff it to
show the required changes.  Here's the complete file that makes us a good
citizen under Mac OS X 10.2

Comment 2

[Anthony DeRobertis]

Nominating for 1.1

Also, why are gopher, news, and ftp missing from the URL list? I think there may
be a few more Mozilla can handle, too.

Comment 3

[Steve Dagley]

All the other types would be ok but I only care about getting Mozilla onto the
default browser popup and the htm/html types will do that.

Comment 4

[Jaime Rodriguez, Jr.]

Makes us the default in the Mac OS X, when the user wants us to be the default
... seems like a good thing to do. 

No ADT approval needed for this one, as repackaging for Mozilla, only.

Can we do the same thing for the commercial branch too? If yes, pls gen' up a
patch and a bug, so we can get it landed asap.

Comment 5

[wighta]

Attachment: Plst checker--a freeware drag & drop app to check 'plst' resources

Comment 6

[wighta]

I checked the draft revised plst for Mozilla using Plst Checker--see attachment
(id=93206), and it gave the following result :

"UTF-8 Encoding Check:
  Bad UTF-8 on line 165 (Mac Roman copyright symbol)
  Bad UTF-8 on line 169 (Mac Roman copyright symbol)
Error parsing property list: Close tag on line 22 does not match open tag array"

so some minor corrections appear to be needed.

BTW why leave out gopher, news, and ftp seeing as you are working on this now ?

Comment 7

[J.J. Enser]

I'll keep "plst checker" around, but even before trying it, I noticed the
following in the mozilla.plst proposed in attachment #93153 [details]
- A <dict> tag is missing after line 7. (this could explain the error wighta
just reported)
- now that file types have been split between "HTML Document" and "Text file",
the  first one is missing a <CFBundleTypeIconFile> key & value.

Note that I have no problem doing a cvs diff on mozilla.plst in MacCVS despite
the -kb flags.

Comment 8

[Steve Dagley]

Attachment: Patch to add HTML CFBundleURLTypes to Mozilla plist

Thanks for the report of the missing <dict>.  Adding a .plst to my file
mappings in MacCVS Pro also allowed a diff so here's a new patch

Comment 9

[Steve Dagley]

Forgot to add that the change is as minimal as possible to do what's needed for
recognition as a default browser choice in Mac OS X 10.2.  That is _all_ I care
about for this bug.  Please file an RFE if you think other types need to be added.

Comment 10

[Simon Fraser [no longer active]]

Attachment: Revised Info.plist file, in UTF-8

Revised Info.plist file, fixing the XML, adding an icon entry for HTML, and
adding	CFBundleLongVersionString and NSAppleScriptEnabled entries. Copyright
symbols have also been converted to UTF-8.

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 93211 [details] [diff] [review]
Patch to add HTML CFBundleURLTypes to Mozilla plist

Whoops, sorry steve, didn't mean to obsolete this one.

Comment 12

[Simon Fraser [no longer active]]

Attachment: Last attachment in the form of a patch

Comment 13

[Steve Dagley]

Comment on attachment 93225 [details] [diff] [review]
Last attachment in the form of a patch

r=sdagley

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 93225 [details] [diff] [review]
Last attachment in the form of a patch

a=asa (on behalf of drivers) for checkin to 1.1

Comment 15

[J.J. Enser]

we also need adt's approval to get this in the 1.0 branch, adding adt1.0.1
keyword in this purpose. (Jaime, please correct me if this is not right).

Comment 16

[J.J. Enser]

Comment on attachment 93225 [details] [diff] [review]
Last attachment in the form of a patch

I'm not sure I understand the need for the UTF8 '©' as  we never used this
encoding before. I'm afraid it will appear as is in the Finder.

Also, why is this part of the patch:
-	<key>CFBundleExecutable</key>
-	<string>Mozilla</string>
+	<key>CFBundleExecutable</key>
+	<string>Mozilla</string>

Comment 17

[Jaime Rodriguez, Jr.]

jj: from what dagley has told ME, this is packign change for Mozilla only, and
will not effect the commercial builds. if this is the case, then we do not need
ADT's approval. thanks!

Comment 18

[Simon Fraser [no longer active]]

jj: jamie said above:
>No ADT approval needed for this one, as repackaging for Mozilla, only.

> I'm not sure I understand the need for the UTF8 '©' as  we never used this
> encoding before. I'm afraid it will appear as is in the Finder.

The copyright symbol is not a legal UTF-8 entitity. And you see '©' when
looking at the patch in the browser because the browser is assuming US-ASCII,
not UTF-8.

>Also, why is this part of the patch:

Whitespace changes.

Comment 19

[J.J. Enser]

Comment on attachment 93225 [details] [diff] [review]
Last attachment in the form of a patch

sr=jj
I've tested this patch against today's build and the copyright string appears
ok under OSX's File browser and Get Info box.
This proves that the info.plst file overwrites any 'plst' or 'vers' resources
found in the binary.

Comment 20

[J.J. Enser]

1 more comment: the patch in attachment 93225 [details] [diff] [review] is based on revision 1.8.6.2 when
the tip of the 1.0 branch is 1.8.6.3 (diff is app version 1.0.1 instead of 1.0).

Also, and for the same reason, a new patch will be needed for the trunk since
the app version is currently 1.1b

Comment 21

[Simon Fraser [no longer active]]

Taking

Comment 22

[Simon Fraser [no longer active]]

Updated Mozilla.plst files checked into the MOZILLA_1_0_BRANCH and the tip, with
appropriate verseion numbers.

Comment 23

[Jaime Rodriguez, Jr.]

marking as fixed1.0.1 per Comment #22 From Simon Fraser.