196.52 KB, application/mac-binhex40
4.25 KB, text/plain
3.01 KB, patch
Steve Dagley: review+
J.J. Enser: superreview+
|Details | Diff | Splinter Review|
The current info.plist file for Mozilla does not contain a CFBundleURLTypes entry. Without such an entry specifying we can handle URLs of type http & https we will not show up as a choice for default browser in the Internet prefs pane in System Preferences under Mac OS X 10.2. Our CFBundleDocumentTypes entry also incorrectly lists .html and .htm files as text files rather than HTML Documents.
Created attachment 93153 [details] Revised source for Mozilla plist Since the @#$^& file in the repository is checked in -kb I can't diff it to show the required changes. Here's the complete file that makes us a good citizen under Mac OS X 10.2
Nominating for 1.1 Also, why are gopher, news, and ftp missing from the URL list? I think there may be a few more Mozilla can handle, too.
Keywords: mozilla1.1, patch
All the other types would be ok but I only care about getting Mozilla onto the default browser popup and the htm/html types will do that.
Keywords: adt1.0.1, mozilla1.0.1, nsbeta1+
Priority: -- → P2
Whiteboard: [adt3 RTM] [ETA 07/30]
Target Milestone: --- → mozilla1.0.1
Whiteboard: [adt3 RTM] [ETA 07/30] → [adt2 RTM] [ETA 07/30]
Makes us the default in the Mac OS X, when the user wants us to be the default ... seems like a good thing to do. No ADT approval needed for this one, as repackaging for Mozilla, only. Can we do the same thing for the commercial branch too? If yes, pls gen' up a patch and a bug, so we can get it landed asap.
Created attachment 93206 [details] Plst checker--a freeware drag & drop app to check 'plst' resources
I checked the draft revised plst for Mozilla using Plst Checker--see attachment (id=93206), and it gave the following result : "UTF-8 Encoding Check: Bad UTF-8 on line 165 (Mac Roman copyright symbol) Bad UTF-8 on line 169 (Mac Roman copyright symbol) Error parsing property list: Close tag on line 22 does not match open tag array" so some minor corrections appear to be needed. BTW why leave out gopher, news, and ftp seeing as you are working on this now ?
I'll keep "plst checker" around, but even before trying it, I noticed the following in the mozilla.plst proposed in attachment #93153 [details] - A <dict> tag is missing after line 7. (this could explain the error wighta just reported) - now that file types have been split between "HTML Document" and "Text file", the first one is missing a <CFBundleTypeIconFile> key & value. Note that I have no problem doing a cvs diff on mozilla.plst in MacCVS despite the -kb flags.
Created attachment 93211 [details] [diff] [review] Patch to add HTML CFBundleURLTypes to Mozilla plist Thanks for the report of the missing <dict>. Adding a .plst to my file mappings in MacCVS Pro also allowed a diff so here's a new patch
Attachment #93153 - Attachment is obsolete: true
Forgot to add that the change is as minimal as possible to do what's needed for recognition as a default browser choice in Mac OS X 10.2. That is _all_ I care about for this bug. Please file an RFE if you think other types need to be added.
Created attachment 93216 [details] Revised Info.plist file, in UTF-8 Revised Info.plist file, fixing the XML, adding an icon entry for HTML, and adding CFBundleLongVersionString and NSAppleScriptEnabled entries. Copyright symbols have also been converted to UTF-8.
Comment on attachment 93211 [details] [diff] [review] Patch to add HTML CFBundleURLTypes to Mozilla plist Whoops, sorry steve, didn't mean to obsolete this one.
Attachment #93211 - Attachment is obsolete: false
Created attachment 93225 [details] [diff] [review] Last attachment in the form of a patch
Comment on attachment 93225 [details] [diff] [review] Last attachment in the form of a patch r=sdagley
Attachment #93225 - Flags: review+
Comment on attachment 93225 [details] [diff] [review] Last attachment in the form of a patch a=asa (on behalf of drivers) for checkin to 1.1
Attachment #93225 - Flags: approval+
we also need adt's approval to get this in the 1.0 branch, adding adt1.0.1 keyword in this purpose. (Jaime, please correct me if this is not right).
Comment on attachment 93225 [details] [diff] [review] Last attachment in the form of a patch I'm not sure I understand the need for the UTF8 '©' as we never used this encoding before. I'm afraid it will appear as is in the Finder. Also, why is this part of the patch: - <key>CFBundleExecutable</key> - <string>Mozilla</string> + <key>CFBundleExecutable</key> + <string>Mozilla</string>
jj: from what dagley has told ME, this is packign change for Mozilla only, and will not effect the commercial builds. if this is the case, then we do not need ADT's approval. thanks!
jj: jamie said above: >No ADT approval needed for this one, as repackaging for Mozilla, only. > I'm not sure I understand the need for the UTF8 '©' as we never used this > encoding before. I'm afraid it will appear as is in the Finder. The copyright symbol is not a legal UTF-8 entitity. And you see '©' when looking at the patch in the browser because the browser is assuming US-ASCII, not UTF-8. >Also, why is this part of the patch: Whitespace changes.
Comment on attachment 93225 [details] [diff] [review] Last attachment in the form of a patch sr=jj I've tested this patch against today's build and the copyright string appears ok under OSX's File browser and Get Info box. This proves that the info.plst file overwrites any 'plst' or 'vers' resources found in the binary.
Attachment #93225 - Flags: superreview+
1 more comment: the patch in attachment 93225 [details] [diff] [review] is based on revision 22.214.171.124 when the tip of the 1.0 branch is 126.96.36.199 (diff is app version 1.0.1 instead of 1.0). Also, and for the same reason, a new patch will be needed for the trunk since the app version is currently 1.1b
Assignee: sdagley → sfraser
Updated Mozilla.plst files checked into the MOZILLA_1_0_BRANCH and the tip, with appropriate verseion numbers.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
marking as fixed1.0.1 per Comment #22 From Simon Fraser.
You need to log in before you can comment on or make changes to this bug.