1599301 - Switch mail window to use type="folder" instead of rdf templates

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, task)

Description

[Ian Neal]

At the moment mailWindowOverlay and folderPane/mailWidgets use rdf templates to populate folderpickers, we should switch to using menupopup type="folder" from folderWidgets.xml.
This patch does make a change to the Go menu in that the folders now sit as submenu rather than being in a main menu, thus an extra click away but looks tidier and allows the menu to be easily hidden in a standalone message window.
This also ports relevant changes from Bug 439291 (thunderbird doesn't have the account/folder list under the Go menu).

Comment 1

[Ian Neal]

Attachment: Switch to use folderWidgets type="folder"

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: Two new entities in messenger.dtd

Comment 2

[Ian Neal]

Attachment: Switch to use folderWidgets type="folder" v1.1

Needed to update the MsgMoveMessage/MsgCopyMessage callers/functions too.

Comment 3

[Ian Neal]

Attachment: Switch to use folderWidgets type="folder" v1.2

Added SelectMsgFolder function for goFolderMenu to use - could be used elsewhere but want to land other folderPane work first.

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9112562 [details] [diff] [review]
Switch to use folderWidgets type="folder" v1.2

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/20be22b77f86
Switch mail window to use type="folder" instead of rdf templates. r=frg