1599327 - Use cluster scrollbar flags to select picture cache tile size.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Glenn Watson [:gw]]

The picture cache code selects an appropriate tile size to use by considering the size of the content rectangle [1].

We only ever want to create small sized tiles for real scrollbars.

When we decide to create a picture for a scrollbar, it's based on the presence of a tag in the primitive cluster flags [2].

Instead of basing this decision on size, we could propagate those cluster flags when creating the TileCacheInstance. Then, we could only select a scrollbar tile size if this picture has been tagged as a scrollbar.

[1] https://searchfox.org/mozilla-central/rev/0678172d5b5c681061b904c776b668489e3355b0/gfx/wr/webrender/src/picture.rs#1678

[2] https://searchfox.org/mozilla-central/rev/0678172d5b5c681061b904c776b668489e3355b0/gfx/wr/webrender_api/src/display_item.rs#43

Comment 1

[Bert Peers [:bpeers]]

This looks like the perfect excuse to get familiar with picture.rs tile caching :)

Comment 2

[Bert Peers [:bpeers]]

Attachment: Bug 1599327 - Use cluster scrollbar flags to select picture cache tile size.

Comment 3

[Bert Peers [:bpeers]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0d8cc875fc803c1907c568f6b96b56c7a0c3418

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bd9d4f431c4
Use cluster scrollbar flags to select picture cache tile size. r=gw

Comment 5

[Razvan Maries]

Backed out for wrench bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=wrench&revision=1bd9d4f431c4c9f93388bd04a6368cb07398f646

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279608990&repo=autoland&lineNumber=8703

Backout: https://hg.mozilla.org/integration/autoland/rev/d5f4a8f705e9a33ede1105b77e55bec874cf7f68

Comment 6

[Bert Peers [:bpeers]]

Confirmed with [:gw] that failure is benign, so I created a new reference image for the failing test and re-landed the change with the image.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b3093f69e87
Use cluster scrollbar flags to select picture cache tile size. r=gw

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/2b3093f69e87

Comment 9

[Bert Peers [:bpeers]]

I'm asking for a backout; between the issue of scrollbar clusters not being on a slice by themselves, and now flickering black squares, I don't think I'll be able to resolve these fast enough.

Comment 10

[Andreea Pavel [:apavel]]

Backed out for causing bugs 1601865, 1601924, 1602500

Backout: https://hg.mozilla.org/integration/autoland/rev/f47661feecce9b319848f7d77202cfa67334be8f

Comment 11

[Bert Peers [:bpeers]]

Thanks Andreea!

Comment 12

[Andreea Pavel [:apavel]]

(In reply to Bert Peers [:bpeers] from comment #11)

Thanks Andreea!

Any time!

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bpeers, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 14

[Bert Peers [:bpeers]]

It landed, but was backed out, not sure what the bot wants me to do. Clearing NMI.

Comment 15

[Bert Peers [:bpeers]]

Compilation push before re-landing:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e396f243d7a11cea5b1667ec5662d5dbf7c9ef1
Performance Talos:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a0a13935ca34592d369613c4e63a46d00ff14d4

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/269ab6499d32
Use cluster scrollbar flags to select picture cache tile size. r=gw

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/269ab6499d32