1599415 - Firefox macOS is doesn't trigger focus event when someone uses mouse to click a details summary

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Lauri Eskola]

Attachment: Details-focus--Firefox-OSX.gif

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36

Steps to reproduce:

Please note that this problem is only with the macOS version of Firefox. It works fine on Windows and Linux (Ubuntu).

When a details summary is clicked with a mouse, the focus effect is not visible. If I use <Tab> key to navigate then the focus effect is visible. Here is an example:

https://jsfiddle.net/lauriii/9t64fjap/

Actual results:

The focus is moved on the details summary but the focus effect is not visible, whereas it most likely should have been. The focus effect is visible in Windows/Linux version, as well as other major browsers on macOS such as Safari and Chrome.

Expected results:

The focus should be moved on the details summary and the focus effect should be visible when clicking a details summary.

Comment 1

[Lauri Eskola]

I just realized this problem is wider than just the focus effect. It seems like the focus event isn't triggered at all when details summary is clicked with a mouse on macOS version of Firefox: https://jsfiddle.net/lauriii/9t64fjap/1/

Comment 2

[Peter Magyari (Desktop QA)]

Hi Lauri,

I can reproduce this using Firefox 70.0.1 and Firefox Nightly 72.0a1 on MacOS 10.15 and Windows 10 as well.
I will set a component in order to involve the development team in reviewing this issue.

Thank you for reporting!

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Mac has different focus handling in general, and Firefox tries to follow OS conventions.

Lauri, is this a regression or has the behavior been the same in older versions of Firefox?

Comment 4

[Lauri Eskola]

(In reply to Olli Pettay [:smaug] from comment #3)

Mac has different focus handling in general, and Firefox tries to follow OS conventions.

Lauri, is this a regression or has the behavior been the same in older versions of Firefox?

It doesn't look like an OS convention because Safari and Chrome on macOS both trigger focus event on when details summary is clicked with a pointer device.

I could reproduce this problem with Firefox 49.0 which according to MDN was the first Firefox release to support details. Therefore I don't believe this would be a regression.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(Chrome doesn't follow OS conventions on MacOS)

Thanks for testing.

Comment 6

[Keith Cirkel]

Attachment: Bug 1599415 trigger `focus` when details summary element is clicked r?TYLin

Depends on D72602

Comment 7

[Narcis Beleuzu [:NarcisB]]

Patch failed to land.
" Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

applying /tmp/tmpTkvc5x
widget/gtk/mozcontainer.cpp
Hunk #9 FAILED at 595.
1 out of 15 hunks FAILED -- saving rejects to file widget/gtk/mozcontainer.cpp.rej
abort: patch command failed: exited with status 256 "

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ea874b6ead8
trigger `focus` when details summary element is clicked r=TYLin,smaug

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I reland the patch via Lando.

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1ea874b6ead8

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23428 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot