1599445 - Investigate refactoring CCRunnerFired to make it easier to follow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Jon Coppeard (:jonco)]

I find the CCRunnerFired function pretty hard to follow. Mostly this is because control doesn't move linearly between the branches of the main if-statement but jumps between them on subsequent calls. And also it can recursively call itself which is confusing in itself.

I'd like to refactor this to make it easier to follow.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1599445 - Refactor CCRunnerFired function by writing it as a state machine r?mccr8

This makes the function into a state machine implemented with a switch statement and gets rid of the recursive call. This results in a little duplication of logic but hopefully it is easier to understand overall. What do you think?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8533b22dc9b
Refactor CCRunnerFired function by writing it as a state machine r=mccr8

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f8533b22dc9b