Closed Bug 1599446 Opened 11 months ago Closed 10 months ago

Feed subscriptions empty for new account, in SeaMonkey

Categories

(MailNews Core :: Account Manager, defect)

defect
Not set
normal

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr fixed)

RESOLVED FIXED
Thunderbird 72.0
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Keywords: leave-open)

Attachments

(2 files, 3 obsolete files)

After the landing of patches from Bug 1339248 when a new RSS account is added, if you try to add a subscription from the context menu or account central the feed-subscription dialog has no folder listed. This happens because the feed options have not been initialised (see https://dxr.mozilla.org/comm-esr60/source/mailnews/extensions/newsblog/content/FeedUtils.jsm#184-185). feed-subscription dialog assumes that it then has a valid treeBox so at https://dxr.mozilla.org/comm-esr60/source/mailnews/extensions/newsblog/content/FeedUtils.jsm#851 the JS bombs out before completing the feed options initialisation. I'm going to fix put a fix into AccountWizard.js to match FeedUtils' createRssAccount

Attached patch init feed options (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): 1339248
User impact if declined: have to go into account settings to subscribe to feeds
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Attachment #9111592 - Flags: review?(frgrahl)
Attachment #9111592 - Flags: approval-comm-release?
Attachment #9111592 - Flags: approval-comm-esr60?
Component: MailNews: Account Configuration → Account Manager
Product: SeaMonkey → MailNews Core
Target Milestone: --- → Thunderbird 72.0

Patch for comm-central

Attachment #9111635 - Flags: review?(alta88)
Attached patch init feed options for SM (obsolete) — Splinter Review

Patch for older branches (pre 68)

Attachment #9111592 - Attachment is obsolete: true
Attachment #9111592 - Flags: review?(frgrahl)
Attachment #9111592 - Flags: approval-comm-release?
Attachment #9111592 - Flags: approval-comm-esr60?
Attachment #9111637 - Flags: review?(frgrahl)
Attachment #9111637 - Flags: approval-comm-release?
Attachment #9111637 - Flags: approval-comm-esr60?
Comment on attachment 9111635 [details] [diff] [review]
1599446-feed-options-init-cc.patch

Review of attachment 9111635 [details] [diff] [review]:
-----------------------------------------------------------------

Feed account creation diverged from the old account wizard long ago and the UI is ifdefed for this, so you can probably just do what you need for SM bits.

This patch is fine on visual inspection, so r+.

But I would really suggest the better future proof way would be to create an account in SM wizard by calling FeedUtils.createRssAccount(), which returns the account, and go from there. For example, I was once considering removing local folder creation; for an install with only a feeds (or chat) account it's not needed.
Attachment #9111635 - Flags: review?(alta88) → review+
Summary: Feed subscriptions empty for new account → Feed subscriptions empty for new account, in SeaMonkey

Something like this?

Attachment #9111635 - Attachment is obsolete: true
Attachment #9112319 - Flags: review?(alta88)

Equivalent for older branches.

Attachment #9111637 - Attachment is obsolete: true
Attachment #9111637 - Flags: review?(frgrahl)
Attachment #9111637 - Flags: approval-comm-release?
Attachment #9111637 - Flags: approval-comm-esr60?
Attachment #9112321 - Flags: review?(frgrahl)
Attachment #9112321 - Flags: approval-comm-release?
Attachment #9112321 - Flags: approval-comm-esr60?
Attachment #9112321 - Attachment description: Use createRssAccount esr60 patch → Use createRssAccount 2.53 patch
Comment on attachment 9112319 [details] [diff] [review]
Use createRssAccount cc patch

Exactly.
Attachment #9112319 - Flags: review?(alta88) → review+
Comment on attachment 9112321 [details] [diff] [review]
Use createRssAccount 2.53 patch

LGTM
Attachment #9112321 - Flags: review?(frgrahl)
Attachment #9112321 - Flags: review+
Attachment #9112321 - Flags: approval-comm-release?
Attachment #9112321 - Flags: approval-comm-release+
Attachment #9112321 - Flags: approval-comm-esr60?
Attachment #9112321 - Flags: approval-comm-esr60+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a0470cab33c0
Feed subscriptions empty for new account r=alta88

TB not affected? No uplift to ESR 68?

TB not affected?
No. Not using server-type

No uplift to ESR 68?
Not needed. SeaMonkey only and we do not plan to do a ESR68 based build.

https://hg.mozilla.org/releases/comm-esr60/rev/af58459229997dc04d4b4171c429a4b0292740ba

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.