1599446 - Feed subscriptions empty for new account, in SeaMonkey

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Ian Neal]

After the landing of patches from Bug 1339248 when a new RSS account is added, if you try to add a subscription from the context menu or account central the feed-subscription dialog has no folder listed. This happens because the feed options have not been initialised (see https://dxr.mozilla.org/comm-esr60/source/mailnews/extensions/newsblog/content/FeedUtils.jsm#184-185). feed-subscription dialog assumes that it then has a valid treeBox so at https://dxr.mozilla.org/comm-esr60/source/mailnews/extensions/newsblog/content/FeedUtils.jsm#851 the JS bombs out before completing the feed options initialisation. I'm going to fix put a fix into AccountWizard.js to match FeedUtils' createRssAccount

Comment 1

[Ian Neal]

Attachment: init feed options

[Approval Request Comment]
Regression caused by (bug #): 1339248
User impact if declined: have to go into account settings to subscribe to feeds
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 2

[Ian Neal]

Attachment: 1599446-feed-options-init-cc.patch

Patch for comm-central

Comment 3

[Ian Neal]

Attachment: init feed options for SM

Patch for older branches (pre 68)

Comment 4

[alta88]

Comment on attachment 9111635 [details] [diff] [review]
1599446-feed-options-init-cc.patch

Review of attachment 9111635 [details] [diff] [review]:
-----------------------------------------------------------------

Feed account creation diverged from the old account wizard long ago and the UI is ifdefed for this, so you can probably just do what you need for SM bits.

This patch is fine on visual inspection, so r+.

But I would really suggest the better future proof way would be to create an account in SM wizard by calling FeedUtils.createRssAccount(), which returns the account, and go from there. For example, I was once considering removing local folder creation; for an install with only a feeds (or chat) account it's not needed.

Comment 5

[Ian Neal]

Attachment: Use createRssAccount cc patch

Something like this?

Comment 6

[Ian Neal]

Attachment: Use createRssAccount 2.53 patch

Equivalent for older branches.

Comment 7

[alta88]

Comment on attachment 9112319 [details] [diff] [review]
Use createRssAccount cc patch

Exactly.

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9112321 [details] [diff] [review]
Use createRssAccount 2.53 patch

LGTM

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a0470cab33c0
Feed subscriptions empty for new account r=alta88

Comment 10

[Jorg K (CEST = GMT+2)]

TB not affected? No uplift to ESR 68?

Comment 11

[Frank-Rainer Grahl (:frg)]

TB not affected?
No. Not using server-type

No uplift to ESR 68?
Not needed. SeaMonkey only and we do not plan to do a ESR68 based build.

https://hg.mozilla.org/releases/comm-esr60/rev/af58459229997dc04d4b4171c429a4b0292740ba

Comment 12

[Ian Neal]

In gitlab 2.53.1 beta 1 tree - https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/commit/4b210521e96f2af492855dec64d4e5eafbab0aa9