1599479 - Crash in [@ AsyncShutdownTimeout | profile-before-change | SessionFile: Finish writing Session Restore data,SessionFile: Finish writing Session Restore data,SessionFile: Finish writing Session Restore data,SessionFile: Finish writing Session Restore da...

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[[:philipp]]

This bug is for crash report bp-6621e884-20a4-4774-8e18-572940191126.

AsyncShutdownTimeout:
{

    "phase":"profile-before-change",
    "conditions":[
        {
            "name":"SessionFile: Finish writing Session Restore data",
            "state":{
                "options":{
                    "isFinalWrite":false,
                    "performShutdownCleanup":false
                },
                "attempts":116,
                "successes":0,
                "failures":0
            },
            "filename":"resource:///modules/sessionstore/SessionFile.jsm",
            "lineNumber":478,
            "stack":[
                "resource:///modules/sessionstore/SessionFile.jsm:write:478",
                "resource:///modules/sessionstore/SessionFile.jsm:write:75",
                "resource:///modules/sessionstore/SessionSaver.jsm:_writeState:360",
                "resource:///modules/sessionstore/SessionSaver.jsm:_saveState:294",
                "resource:///modules/sessionstore/SessionSaver.jsm:_saveStateAsync:344",
                "resource:///modules/sessionstore/SessionSaver.jsm:saveStateAsyncWhenIdle:191",
                "resource://gre/modules/Timer.jsm:callback:125"
            ]
        },
		...
        {
            "name":"SessionFile: Finish writing Session Restore data",
            "state":{
                "options":{
                    "isFinalWrite":true,
                    "performShutdownCleanup":true
                },
                "attempts":116,
                "successes":0,
                "failures":0
            },
            "filename":"resource:///modules/sessionstore/SessionFile.jsm",
            "lineNumber":478,
            "stack":[
                "resource:///modules/sessionstore/SessionFile.jsm:write:478",
                "resource:///modules/sessionstore/SessionFile.jsm:write:75",
                "resource:///modules/sessionstore/SessionSaver.jsm:_writeState:360",
                "resource:///modules/sessionstore/SessionSaver.jsm:_saveState:294",
                "resource:///modules/sessionstore/SessionSaver.jsm:run:154",
                "resource:///modules/sessionstore/SessionSaver.jsm:run:69",
                "resource:///modules/SessionStore.jsm:ssi_uninit:844",
                "resource:///modules/SessionStore.jsm:ssi_onQuitApplication:1980",
                "resource:///modules/SessionStore.jsm:ssi_observe:878"
            ]
        }
    ]

}

this shutdown hang signature is getting worse in firefox 70 - it's mostly affecting users of zh-cn builds.

Comment 1

[Pascal Chevrel:pascalc]

Mike, could this bug be prioritized and triaged wrt to our upcoming releases? Thanks

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like crash volume is slightly better on 71 than on 70.0.1. Hard to tell if that's because something got fixed or because we lost those users though.

Comment 3

[Mike de Boer [:mikedeboer]]

So comment 0 tells us there have been 116 attempts at flushing the sessionstore.jsonlz4 file to disk, but has failed to do so every time. To be clear: this file was never reported to be saved successfully EVER(!)
Also, 0 failures were reported, so this must mean that something for these users causes a hard crash in the ChromeWorker where the file is written in a different (background-)thread, but somehow still keeps the worker itself alive. At this point the only thing I can think of to fix this shutdown crash is to move SessionStore away from using OS.File to something more reliable, perhaps? That may be something for our Storage workgroup to ponder over, but it's unfortunately not actionable.

Unless somehow one of these users turns up with a reproducible scenario, I don't think this is something we can track effectively.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.