1599557 - Crash in PerformBackgroundCacheRevalidation while loading flash page

Status: RESOLVED DUPLICATE of bug 1600331

(Core :: Networking, defect)

Description

[Brendan Dahl [:bdahl]]

On a debug ubuntu build

Str:

1. open https://helpx.adobe.com/flash-player.html

backtrace

#0  0x00007fffe59ae612 in mozilla::PrioritizedEventQueue::PutEvent(already_AddRefed<nsIRunnable>&&, mozilla::EventQueuePriority, mozilla::BaseAutoLock<mozilla::Mutex&> const&, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator>*) (this=0x7fffdf3b72a0, aEvent=..., aPriority=<optimized out>, aProofOfLock=..., aDelay=0x0)
    at /home/bdahl/projects/gecko/xpcom/threads/PrioritizedEventQueue.cpp:68
#1  0x00007fffe59cdbd2 in mozilla::ThreadEventQueue<mozilla::PrioritizedEventQueue>::PutEventInternal(already_AddRefed<nsIRunnable>&&, mozilla::EventQueuePriority, mozilla::ThreadEventQueue<mozilla::PrioritizedEventQueue>::NestedSink*) (this=0x7fffdf373200, aEvent=..., aPriority=mozilla::EventQueuePriority::Idle, aSink=0x0) at /home/bdahl/projects/gecko/xpcom/threads/ThreadEventQueue.cpp:113
#2  0x00007fffe59c24c9 in nsThread::DispatchToQueue(already_AddRefed<nsIRunnable>, mozilla::EventQueuePriority) (this=<optimized out>, aEvent=..., aQueue=mozilla::EventQueuePriority::Idle) at /home/bdahl/projects/gecko/xpcom/threads/nsThread.cpp:959
#3  0x00007fffe59c64d7 in NS_DispatchToThreadQueue(already_AddRefed<nsIRunnable>&&, nsIThread*, mozilla::EventQueuePriority) (aEvent=..., aThread=0x7ffff68a5600, aQueue=mozilla::EventQueuePriority::Idle)
    at /home/bdahl/projects/gecko/xpcom/threads/nsThreadUtils.cpp:293
#4  0x00007fffe59c9450 in NS_DispatchToMainThreadQueue(already_AddRefed<nsIRunnable>&&, mozilla::EventQueuePriority) (aEvent=..., aQueue=mozilla::EventQueuePriority::Idle) at /home/bdahl/projects/gecko/xpcom/threads/nsThreadUtils.cpp:315
#5  0x00007fffe5e90f46 in mozilla::net::nsHttpChannel::PerformBackgroundCacheRevalidation() (this=<optimized out>)
    at /home/bdahl/projects/gecko/netwerk/protocol/http/nsHttpChannel.cpp:10473
#6  0x00007fffe5e90236 in mozilla::net::nsHttpChannel::OnCacheEntryCheck(nsICacheEntry*, nsIApplicationCache*, unsigned int*) (this=
    0x7fffca93d000, entry=0x7fffca723880, appCache=<optimized out>, aResult=0x7fffd9ff0abc)
    at /home/bdahl/projects/gecko/netwerk/protocol/http/nsHttpChannel.cpp:4532
#7  0x00007fffe5d5b719 in mozilla::net::CacheEntry::InvokeCallback(mozilla::net::CacheEntry::Callback&) (this=0x7fffca90e940, aCallback=...) at /home/bdahl/projects/gecko/netwerk/cache2/CacheEntry.cpp:741
#8  0x00007fffe5d5b332 in mozilla::net::CacheEntry::InvokeCallbacks(bool) (this=<optimized out>, aReadOnly=<optimized out>)
    at /home/bdahl/projects/gecko/netwerk/cache2/CacheEntry.cpp:668
#9  0x00007fffe5d59711 in mozilla::net::CacheEntry::InvokeCallbacks() (this=0x7fffca90e940)
    at /home/bdahl/projects/gecko/netwerk/cache2/CacheEntry.cpp:610
#10 0x00007fffe5d5a8e3 in mozilla::net::CacheEntry::OnFileReady(nsresult, bool) (this=0x7fffca90e940, aResult=<optimized out>, aIsNew=<optimized out>) at /home/bdahl/projects/gecko/netwerk/cache2/CacheEntry.cpp:498
#11 0x00007fffe5d5aa9f in non-virtual thunk to mozilla::net::CacheEntry::OnFileReady(nsresult, bool) ()
    at /home/bdahl/projects/gecko/obj/opt.debug.sccache/dist/bin/libxul.so
#12 0x00007fffe5d647d9 in mozilla::net::CacheFile::OnMetadataRead(nsresult) (this=<optimized out>, aResult=nsresult::NS_OK)
    at /home/bdahl/projects/gecko/netwerk/cache2/CacheFile.cpp:643
#13 0x00007fffe5d64e69 in non-virtual thunk to mozilla::net::CacheFile::OnMetadataRead(nsresult) ()
    at /home/bdahl/projects/gecko/obj/opt.debug.sccache/dist/bin/libxul.so
#14 0x00007fffe5d84e7b in mozilla::net::CacheFileMetadata::OnDataRead(mozilla::net::CacheFileHandle*, char*, nsresult) (this=0x7fffca722660, aHandle=<optimized out>, aBuf=<optimized out>, aResult=<optimized out>)
    at /home/bdahl/projects/gecko/netwerk/cache2/CacheFileMetadata.cpp:699
#15 0x00007fffe5d9b72e in mozilla::net::ReadEvent::Run() (this=<optimized out>)
    at /home/bdahl/projects/gecko/netwerk/cache2/CacheFileIOManager.cpp:704
#16 0x00007fffe5d885b8 in mozilla::net::CacheIOThread::LoopOneLevel(unsigned int) (this=0x7fffdf30c0e0, aLevel=1)
    at /home/bdahl/projects/gecko/netwerk/cache2/CacheIOThread.cpp:545
#17 0x00007fffe5d882c4 in mozilla::net::CacheIOThread::ThreadFunc() (this=0x7fffdf30c0e0)
    at /home/bdahl/projects/gecko/netwerk/cache2/CacheIOThread.cpp:483
#18 0x00007fffe5d87c7a in mozilla::net::CacheIOThread::ThreadFunc(void*) (aClosure=0x7ffff6e67680 <_IO_2_1_stderr_>)
    at /home/bdahl/projects/gecko/netwerk/cache2/CacheIOThread.cpp:424
#19 0x00007ffff7f8487b in _pt_root (arg=0x7fffd832b5e0) at /home/bdahl/projects/gecko/nsprpub/pr/src/pthreads/ptthread.c:201
#20 0x00007ffff79b66db in start_thread (arg=0x7fffd9ff1700) at pthread_create.c:463

Comment 1

[Brendan Dahl [:bdahl]]

Seems to be intermittent, but I've run into a few times while investigating bug 1598841.

Comment 2

[Honza Bambas (:mayhemer)]

Is this a null deref or what exactly? What changeset are you on?

Comment 3

[Brendan Dahl [:bdahl]]

Assertion failure: NS_IsMainThread() (Should only queue idle runnables on main thread), at /home/bdahl/projects/gecko/xpcom/threads/PrioritizedEventQueue.cpp:69

I'm mozilla central 3d8cfd4a935dad17ab09a64325de2101062eaf1d with no changes.

Comment 4

[Brendan Dahl [:bdahl]]

Updated to current mozilla central and no longer getting a crash.

Comment 5

[Brendan Dahl [:bdahl]]

Spoke too soon, still seeing crashes.