1599580 - Implement install/uninstall Extensions

Status: RESOLVED FIXED

(GeckoView :: Extensions, enhancement, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Design doc: https://docs.google.com/document/d/10Za-_ZqjrDpq-7qTOZ05k5IGkj8R2ttj5zB_3l8nX1Q/edit

This tracks implementing install/uninstall/installBuiltIn from the doc.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1599580 - Make Extensions.get(id) asynchronous.

This is a pre-requisite for making extensions persistent, as sometimes we have
to fetch state from Gecko, so getting the extension needs to be async.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Spinning off installBuiltIn to Bug 1601067.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1599580 - Fix typo in setPromptDelegate.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1599580 - Make GeckoViewWebExtension.extensionById async.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1599580 - Rename blockedReason -> blocklistState.

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1599580 - Implement install/uninstall extension.

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1599580 - Allow null aBrowser in AddonManager.installAddonFromWebpage.

GeckoView will install extensions from the native UI so it doesn't have a
browser object to pass into this method.

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1599580 - Set useAddonManager for extension tests that interact with GeckoView.

Non-AddonManager extensions are invisible to GeckoView, so when a message like
"open a new tab" comes to GeckoView we will ignore them unless the extension is
properly registered.

Because of this, we need to register them in tests too.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/312f626fb657
Allow null aBrowser in AddonManager.installAddonFromWebpage. r=mixedpuppy,snorp
https://hg.mozilla.org/integration/autoland/rev/24d4083da050
Fix typo in setPromptDelegate. r=snorp
https://hg.mozilla.org/integration/autoland/rev/176337e5ba59
Make Extensions.get(id) asynchronous. r=snorp
https://hg.mozilla.org/integration/autoland/rev/e7fbe7147d19
Make GeckoViewWebExtension.extensionById async. r=snorp
https://hg.mozilla.org/integration/autoland/rev/51a8fbed80c3
Rename blockedReason -> blocklistState. r=snorp
https://hg.mozilla.org/integration/autoland/rev/7dc53077d58a
Set useAddonManager for extension tests that interact with GeckoView. r=snorp
https://hg.mozilla.org/integration/autoland/rev/64fd40663930
Implement install/uninstall extension. r=snorp,esawin

Comment 10

[Stefan Hindli [:stefan_hindli]]

Backed out 7 changesets (Bug 1599580) for causing linting opt failure CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=279894960

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279894960&repo=autoland&lineNumber=1135

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa933e86341b
Backed out 7 changesets for causing linting opt failure CLOSED TREE

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f00e026cc99b
Allow null aBrowser in AddonManager.installAddonFromWebpage. r=mixedpuppy,snorp
https://hg.mozilla.org/integration/autoland/rev/8ea43c8cf1e8
Fix typo in setPromptDelegate. r=snorp
https://hg.mozilla.org/integration/autoland/rev/088580001d18
Make Extensions.get(id) asynchronous. r=snorp
https://hg.mozilla.org/integration/autoland/rev/4009a6313f44
Make GeckoViewWebExtension.extensionById async. r=snorp
https://hg.mozilla.org/integration/autoland/rev/39436056f305
Rename blockedReason -> blocklistState. r=snorp
https://hg.mozilla.org/integration/autoland/rev/1b7ed3d0de92
Set useAddonManager for extension tests that interact with GeckoView. r=snorp
https://hg.mozilla.org/integration/autoland/rev/7bc82062b998
Implement install/uninstall extension. r=snorp,esawin

Comment 13

[[ex-Mozilla] Agi Sferro | :agi]

Made a last minute change and forgot to update apilint, sorry about that!

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f00e026cc99b
https://hg.mozilla.org/mozilla-central/rev/8ea43c8cf1e8
https://hg.mozilla.org/mozilla-central/rev/088580001d18
https://hg.mozilla.org/mozilla-central/rev/4009a6313f44
https://hg.mozilla.org/mozilla-central/rev/39436056f305
https://hg.mozilla.org/mozilla-central/rev/1b7ed3d0de92
https://hg.mozilla.org/mozilla-central/rev/7bc82062b998