1599616 - Fix web browser persist toolkit/components/windowcreator/test/browser_bug1204626.js for Fission

Status: RESOLVED FIXED

(Core :: Window Management, task, P2)

Description

[Chris Peterson [:cpeterson]]

Fails in opt: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebBrowserPersist.saveDocument]

Skipped in debug.

Comment 1

[Chris Peterson [:cpeterson]]

Neil, this bug is a blocker for Fission's current milestone (M4.1 aka "fix all the mochitests"), but it's currently unassigned. The Fission team is hoping teams will fix their mochitests for Fission before the end of Q1 (75 or 76 Nightly).

Will your team be able to prioritize this bug for Q1? If you don't think this mochitest failure should block shipping Fission, just let me know

If you have questions for Fission engineers, you can reach them in the #fission channel on Slack or Riot.

Comment 2

[Neil Deakin]

Well this bug is really just 'fix web browser persist' for fission, which I suspect would be a large amount of work. Perhaps Jed who wrote this for e10s could comment on how involved this would be.

My understanding is that this not working would prevent saving web pages (File -> Save Page As)

I guess we should file a proper separate bug though on fixing this.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Neil Deakin from comment #2)

My understanding is that this not working would prevent saving web pages (File -> Save Page As)

We have bug 1576188 for fixing "Save Page As" for Fission.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

I haven't touched WebBrowserPersist for years, but bug 1576188 comment #2 seems to be a pretty good summary of the problem. You'd probably have more luck asking someone from the DOM team.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧ from comment #4)

You'd probably have more luck asking someone from the DOM team.

Sending this bug back to Fission triage to find an appropriate DOM contact.

Comment 6

[Chris Peterson [:cpeterson]]

duping to "Save Page As" bug 1576188

Comment 7

[Chris Peterson [:cpeterson]]

@ farre: I originally closed this bug as a dupe of "Save Page As" bug 1576188, which you fixed, but this browser_bug1204626.js test is still annotated as failing on Fission opt and skipped Fission debug. Can we re-enable this test now that you've fixed bug 1576188?

https://searchfox.org/mozilla-central/rev/7ec7ee4a9bde171ba195ab46ed6077e4baaef34d/toolkit/components/windowcreator/test/browser.ini#1-3

Comment 8

[Chris Peterson [:cpeterson]]

Kashav has a patch in bug 1653674 to try re-enabling this test.

Comment 9

[Andreas Farre [:farre]]

So, it works fine on my machine, so re-enabling should just work. bug 1653674 comment 3 feels strange, it should just work. Is there a try run somewhere?

Comment 10

[u608768]

(In reply to Andreas Farre [:farre] from comment #9)

So, it works fine on my machine, so re-enabling should just work. bug 1653674 comment 3 feels strange, it should just work. Is there a try run somewhere?

So it turns out it also fails in debug builds (very?) intermittently. There's some logs in bug 1620954 comment 15.

Oops, looks like those are all unexpected passes. This can probably be re-enabled everywhere.

Comment 11

[Andreas Farre [:farre]]

Attachment: Bug 1599616 - Enable browser_bug1204626.js for Fission. r=kashav

Comment 12

[Andreas Farre [:farre]]

Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d962339bcd13a162fc3c493f4e1756d2146ffb67

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/673f1a12e21a
Enable browser_bug1204626.js for Fission. r=kashav

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/673f1a12e21a

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for turning browser_bug1204626.js on for fission but perma failing on Linux and Windows shippable and intermittently on Linux debug:

https://hg.mozilla.org/integration/autoland/rev/0effab327cbd040df8390f9ba523be8d45d711e1

List of recent failures: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2020-08-05&endday=2020-08-12&tree=trunk&bug=1656698

• Linux debug intermittent
• Linux x64 shippable opt permanent failure
• Windows x64 shippable opt permanent failure

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/0effab327cbd

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:farre, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 18

[Andreas Farre [:farre]]

Attachment: Bug 1599616 - Don't try to save document when document actor has been destroyed. r=smaug

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b631c11d4acf
Don't try to save document when document actor has been destroyed. r=smaug

Comment 20

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b631c11d4acf