1599639 - Remove unused old about:addons code

Status: NEW

(Toolkit :: Add-ons Manager, task, P3)

Description

[Tim Nguyen :ntim]

These files:
toolkit/mozapps/extensions/content/extensions.css
toolkit/themes/linux/mozapps/extensions/extensions.css
toolkit/themes/osx/mozapps/extensions/extensions.css
toolkit/themes/windows/mozapps/extensions/extensions.css
toolkit/themes/shared/extensions/extensions.inc.css

all contain a lot of code that became unused with the new about:addons parts.

Comment 1

[Tim Nguyen :ntim]

This can also be removed (+its related JS code), I think: https://searchfox.org/mozilla-central/rev/cce8b90aece0f42e5025e45282de16066eeaa662/toolkit/mozapps/extensions/content/extensions.xul#85-114

There are also some images referenced by the CSS files.

Mark, is this something you could look into removing ? There's no value in keeping the old bits around, especially since the pref is no longer around.

There's also some cleanup I also see that could be done after the removal (using <deck> will now be unnecessary in extensions.xul for instance).

Comment 2

[Mark Striemer [:mstriemer]]

Nearly everything is in the HTML document now. I'm starting to look at moving the sidebar categories/support links which would then put everything in the HTML document and we can just rm extensions.css and most of the XUL document until we switch to a HTML root document.

Comment 3

[Deleted Account]

(In reply to Mark Striemer [:mstriemer] from comment #2)

Nearly everything is in the HTML document now. I'm starting to look at moving the sidebar categories/support links which would then put everything in the HTML document and we can just rm extensions.css and most of the XUL document until we switch to a HTML root document.

That's done now!