Closed Bug 1599659 Opened 5 years ago Closed 5 years ago

Add JS_ContainsSharedArrayBuffer(JSContext*)

Categories

(Core :: JavaScript: WebAssembly, task, P3)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: luke, Assigned: lth)

References

Details

Attachments

(1 file)

Bug 1599659 - Predicate to test context for live SABs. r=jonco
47 bytes, text/x-phabricator-request
Details | Review

To implement bug 1563335, I think we need to have a boolean test of whether a given JSContext contains any SABs. I think this can be implemented by simply maintaining a count on the JSContext which is incremented/decremented when we construct/finalize a SAB object (which, iirc, implicitly covers WebAssembly.Memory).

(This will be a conservative query, where all JSContexts containing a SAB will have their execution serialized, but this seems Good Enough for a mitigation we don't expect to use.)

Assignee: nobody → lhansen
Status: NEW → ASSIGNED
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
See Also: → 1577825

I agree, JSContext seems like the right place for this counter. I was initially wondering if we needed to put it on the runtime but there should be no risk of anyone without a context having to account for SABs.

SABs become foreground-finalizable so that we can access the context
during finalization. Then a simple counter on the context will track
live SABs for the context.

Fallout: SABs are now enabled on the globals used for jsapi-tests.

Attachment #9113419 - Attachment description: Bug 1599659 - Predicate to test context for live SABs. r?jonco → Bug 1599659 - Predicate to test context for live SABs. r=jonco
Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2921275a761f Predicate to test context for live SABs. r=jonco

Backed out changeset 2921275a761f for causing bustages in testSABAccounting.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/4c385c7691cef4f18a1a036a0c1ce0c015b11d62

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&resultStatus=testfailed%2Cbusted%2Cexception&tochange=4c385c7691cef4f18a1a036a0c1ce0c015b11d62&fromchange=2921275a761f948319c743f15a4f9031efaf730b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279808592&repo=autoland&lineNumber=6564

[task 2019-12-05T15:08:37.644Z] 15:08:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/i18n'
[task 2019-12-05T15:08:37.700Z] 15:08:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/third_party/prio'
[task 2019-12-05T15:08:37.700Z] 15:08:37 INFO - third_party/prio/client.o
[task 2019-12-05T15:08:37.700Z] 15:08:37 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang -std=gnu99 -o client.o -c -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/third_party/prio -I/builds/worker/workspace/build/src/obj-firefox/third_party/prio -I/builds/worker/workspace/build/src/security/nss/lib/freebl/mpi -I/builds/worker/workspace/build/src/third_party/msgpack/include -I/builds/worker/workspace/build/src/third_party/prio/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fsanitize=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fno-sanitize-recover=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -fPIC -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -MD -MP -MF .deps/client.o.pp /builds/worker/workspace/build/src/third_party/prio/prio/client.c
[task 2019-12-05T15:08:37.700Z] 15:08:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/third_party/prio'
[task 2019-12-05T15:08:37.702Z] 15:08:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/third_party/prio'
[task 2019-12-05T15:08:37.702Z] 15:08:37 INFO - third_party/prio/config.o
[task 2019-12-05T15:08:37.705Z] 15:08:37 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang -std=gnu99 -o config.o -c -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/third_party/prio -I/builds/worker/workspace/build/src/obj-firefox/third_party/prio -I/builds/worker/workspace/build/src/security/nss/lib/freebl/mpi -I/builds/worker/workspace/build/src/third_party/msgpack/include -I/builds/worker/workspace/build/src/third_party/prio/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fsanitize=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fno-sanitize-recover=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -fPIC -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -MD -MP -MF .deps/config.o.pp /builds/worker/workspace/build/src/third_party/prio/prio/config.c
[task 2019-12-05T15:08:37.705Z] 15:08:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/third_party/prio'
[task 2019-12-05T15:08:37.761Z] 15:08:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/libjpeg'
[task 2019-12-05T15:08:37.761Z] 15:08:37 INFO - media/libjpeg/jcapistd.o
[task 2019-12-05T15:08:37.761Z] 15:08:37 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang -std=gnu99 -o jcapistd.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/media/libjpeg -I/builds/worker/workspace/build/src/obj-firefox/media/libjpeg -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fsanitize=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fno-sanitize-recover=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -fPIC -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -MD -MP -MF .deps/jcapistd.o.pp /builds/worker/workspace/build/src/media/libjpeg/jcapistd.c
[task 2019-12-05T15:08:37.761Z] 15:08:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/media/libjpeg'
[task 2019-12-05T15:08:37.789Z] 15:08:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-12-05T15:08:37.789Z] 15:08:37 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_js_src14.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -DNDEBUG=1 -DTRIMMED=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src/ctypes/libffi/include -I/builds/worker/workspace/build/src/js/src/ctypes/libffi/src/x86 -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fno-sanitize-recover=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/js/src/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -MD -MP -MF .deps/Unified_cpp_js_src14.o.pp Unified_cpp_js_src14.cpp
[task 2019-12-05T15:08:37.789Z] 15:08:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-12-05T15:08:37.789Z] 15:08:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-12-05T15:08:37.790Z] 15:08:37 INFO - js/src/Unified_cpp_js_src17.o
[task 2019-12-05T15:08:37.790Z] 15:08:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/third_party/msgpack'
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - third_party/msgpack/vrefbuffer.o
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang -std=gnu99 -o vrefbuffer.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DMSGPACK_DLLEXPORT= -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/third_party/msgpack -I/builds/worker/workspace/build/src/obj-firefox/third_party/msgpack -I/builds/worker/workspace/build/src/third_party/msgpack/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fsanitize=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fno-sanitize-recover=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -fPIC -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -MD -MP -MF .deps/vrefbuffer.o.pp /builds/worker/workspace/build/src/third_party/msgpack/src/vrefbuffer.c
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/third_party/msgpack'
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src/jsapi-tests'
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_js_src_jsapi-tests15.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DEXPORT_JS_API -Dtopsrcdir=/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-firefox/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fno-sanitize-recover=bool,bounds,integer-divide-by-zero,pointer-overflow,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/js/src/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -MD -MP -MF .deps/Unified_cpp_js_src_jsapi-tests15.o.pp Unified_cpp_js_src_jsapi-tests15.cpp
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - In file included from Unified_cpp_js_src_jsapi-tests15.cpp:20:
[task 2019-12-05T15:08:37.828Z] 15:08:37 ERROR - /builds/worker/workspace/build/src/js/src/jsapi-tests/testSABAccounting.cpp:11:35: error: use of undeclared identifier 'GCReason'; did you mean 'JS::GCReason'?
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - NonIncrementalGC(cx, GC_SHRINK, GCReason::API);
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - ^~~~~~~~
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - JS::GCReason
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/js/GCAPI.h:497:12: note: 'JS::GCReason' declared here
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - enum class GCReason {
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - ^
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - In file included from Unified_cpp_js_src_jsapi-tests15.cpp:20:
[task 2019-12-05T15:08:37.828Z] 15:08:37 ERROR - /builds/worker/workspace/build/src/js/src/jsapi-tests/testSABAccounting.cpp:27:35: error: use of undeclared identifier 'GCReason'; did you mean 'JS::GCReason'?
[task 2019-12-05T15:08:37.828Z] 15:08:37 INFO - NonIncrementalGC(cx, GC_SHRINK, GCReason::API);
[task 2019-12-05T15:08:37.829Z] 15:08:37 INFO - ^~~~~~~~
[task 2019-12-05T15:08:37.829Z] 15:08:37 INFO - JS::GCReason
[task 2019-12-05T15:08:37.829Z] 15:08:37 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/js/GCAPI.h:497:12: note: 'JS::GCReason' declared here
[task 2019-12-05T15:08:37.829Z] 15:08:37 INFO - enum class GCReason {
[task 2019-12-05T15:08:37.829Z] 15:08:37 INFO - ^
[task 2019-12-05T15:08:37.829Z] 15:08:37 INFO - 2 errors generated.
[task 2019-12-05T15:08:37.829Z] 15:08:37 INFO - /builds/worker/workspace/build/src/config/rules.mk:804: recipe for target 'Unified_cpp_js_src_jsapi-tests15.o' failed
[task 2019-12-05T15:08:37.829Z] 15:08:37 ERROR - make[4]: *** [Unified_cpp_js_src_jsapi-tests15.o] Error 1
[task 2019-12-05T15:08:37.830Z] 15:08:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src/jsapi-tests'
[task 2019-12-05T15:08:37.830Z] 15:08:37 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-12-05T15:08:37.830Z] 15:08:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-12-05T15:08:37.830Z] 15:08:37 INFO - js/src/Unified_cpp_js_src18.o

Flags: needinfo?(lhansen)

What annoys me more than anything is that it builds locally. This is a problem too often.

/me takes his case to Try

Flags: needinfo?(lhansen)
Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f5b37785d2a Predicate to test context for live SABs. r=jonco

https://hg.mozilla.org/mozilla-central/rev/3f5b37785d2a

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: