[wpt-sync] Sync PR 20472 - [webnfc] Remove NDEFMessage{Init}#url and old impl of the author record.
Categories
(Core :: DOM: Device Interfaces, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 20472 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/20472
Details from upstream follow.
Leon Han <leon.han@intel.com> wrote:
[webnfc] Remove NDEFMessage{Init}#url and old impl of the author record.
The plan is:
Introduces NDEFRecord{Init}#id and supports reading.
Already done by crrev.com/c/1861574.Supports writing.
crrev.com/c/1928891 is focused on impl in Blink, with the following
CLs focused on impl in Device Service.
crrev.com/c/1910906
crrev.com/c/1911385
crrev.com/c/1915940
crrev.com/c/1916261Introduces NFCScanOptions#id and filters records by it when scanning.
Done by crrev.com/c/1936187.Removes NDEFMessage{Init}#url and old impl of the author record.
This CL.The spec changes:
https://github.com/w3c/web-nfc/pull/338
https://github.com/w3c/web-nfc/pull/340
https://github.com/w3c/web-nfc/pull/446BUG=520391
Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c
Reviewed-on: https://chromium-review.googlesource.com/1938835
WPT-Export-Revision: 86c6fe123fe0976db9ec9dcaba9cea1c301a9ede
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 7 tests and 3 subtests
Status Summary
Firefox
OK : 6[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']] 7[['GitHub']]
FAIL: 72[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']] 91[['GitHub']]
Chrome
OK : 7
PASS: 24
FAIL: 67
Safari
OK : 7
FAIL: 91
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/web-nfc/NDEFReader_scan.https.html
Test that NDEFReader.onreading should be fired on an unformatted NFC tag with empty records array for NDEFMessage.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that nfc watch success if NFC HW is enabled.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if signal is not an AbortSignal.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord.toRecords returns its embedded records correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.id is invalid.: FAIL
Test that NDEFReader can not get any reading events once the signal aborts.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that an error event happens if no implementation for NFC Mojo interface is available.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.signal aborts right after the scan invocation.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.onreading should not be fired if the NFC tag does not expose NDEF technology.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan matches any ids if NDEFScanOptions.id is undefined.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan succeeds if NDEFScanOptions.url is valid URL with '' wildcard character in the beginning of path component followed by subpath.: FAIL
NDEFReader.scan should fail if NFC HW is disabled.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan succeeds if NDEFScanOptions.url is valid URL with '' wildcard character in path.: FAIL
Test that NDEFReader.scan rejects if NDEFScanOptions.signal is already aborted.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan succeeds if NDEFScanOptions.url is empty.: FAIL
Test that NDEFReader.scan rejects if NDEFScanOptions.id is missing components.: FAIL
Test that NDEFReader.scan succeeds if NDEFScanOptions.url is valid URL.: FAIL
NDEFReader.scan should fail if user permission is not granted.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.id has wrong protocol.: FAIL
NDEFReader.scan should fail if NFC HW is not supported.: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/NDEFReader_scan_iframe.https.html
Test that NDEFWriter.scan is not suspended if iframe gains focus.: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/NDEFReadingEvent_constructor.https.html
NDEFReadingEvent constructor without init dict: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent constructor with serialNumber not present: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent constructor with null message: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent constructor with null serialNumber: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent constructor with valid parameters: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent constructor does not set NDEFRecord#lang for any text records it embeds: FAIL (Chrome: PASS, Safari: FAIL)
/web-nfc/NDEFWriter_push.https.html
Check that default NDEFPushOptions values are correctly set.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail when the NFC device does not expose NDEF technology.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail if user permission is not granted.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFWriter.push succeeds when message is ArrayBuffer.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that recordType should be set to 'text' if NDEFRecordInit.record's recordType is undefined and NDEFRecordInit.record's data is DOMString.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFWriter.push succeeds when message is DOMString.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that promise is rejected with TypeError if NDEFMessageSource is invalid.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should replace all previously configured push operations.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should succeed when NFC HW is enabled: FAIL (Chrome: FAIL, Safari: FAIL)
Test that recordType should be set to 'mime' if NDEFRecordInit.record's recordType is undefined and NDEFRecordInit.record's data is not DOMString.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail when NFC HW is not supported.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail when NFC HW is disabled.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push NDEFMessage containing text, mime, unknown, url, absolute-url and external records with default NDEFPushOptions.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail if signal is not an AbortSignal.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should fail if abort push request before push happends.: FAIL (Chrome: FAIL, Safari: FAIL)
Synchronously signaled abort.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail when there are NDEF records on the NFC device and NDEFPushOptions.overwrite is false.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should succeed to push data to an unformatted NFC device when the NDEFPushOptions.overwrite is false.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that mediaType should be set to 'application/octet-stream' if NDEFRecordInit.record's recordType is 'mime' and NDEFRecordInit.record's mediaType is undefined.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that promise is rejected with SyntaxError if NDEFMessageSource contains invalid records.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should ignore reading data when ignoreRead is true.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that WebNFC API is not accessible from iframe context.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFWriter.push succeeds when message is ArrayBufferView.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should read data when ignoreRead is false.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail with TypeError when invalid target value is provided.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should fail if signal's aborted flag is set.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should succeed to overwrite the existing data when the NDEFPushOptions.overwrite is true.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail if no implementation for NFC Mojo interface is available.: FAIL (Chrome: FAIL, Safari: FAIL)
Reject promise with NotSupportedError if NFC message size exceeds 32KB.: FAIL (Chrome: PASS, Safari: FAIL)
Check that provided NDEFPushOptions values are correctly converted.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push with 'empty' record should succeed.: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/NDEFRecord_constructor.https.html
NDEFRecord constructor with absolute-url record type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type and arrayBuffer data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with empty record type and id: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor should only accept mediaType for mime record type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord constructor with external record type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with custom record ids: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with url record type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor without init dict: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord constructor with record type string being treated as case sensitive: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord constructor with mime record type and json data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with invalid external record type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord constructor with mime record type and stream data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type and custom document language: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with unknown record type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type and string data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type, encoding, and lang: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type and arrayBufferView data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with null init dict: FAIL (Chrome: PASS, Safari: FAIL)
/web-nfc/NDEFReader_scan_filter.https.html
Test that reading data succeed when NDEFScanOptions' recordType is set to 'unknown'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'mime' record from different messages correctly with NDEFScanOptions' mediaType set.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'text'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'empty' record from different messages correctly with NDEFScanOptions' recordType is set to 'empty'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'text' record from different messages correctly with NDEFScanOptions' id set.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering external record from different messages correctly with NDEFScanOptions' recordType is set to the custom type.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'absolute-url' record from different messages correctly with NDEFScanOptions' recordType is set to 'absolute-url'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'absolute-url'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that the id of NDEFScanOptions filters relevant data sources correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'mime'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'url' record from different messages correctly with NDEFScanOptions' recordType is set to 'url'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that the mediaType of NDEFScanOptions filters relevant data sources correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'url'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to a custom type for external type records.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'empty'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'text' record from different messages correctly with NDEFScanOptions' recordType is set to 'text'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'mime' record from different messages correctly with NDEFScanOptions' recordType is set to 'mime'.: FAIL (Chrome: FAIL, Safari: FAIL)
Multiple scan() from the same NDEFReader object with new options should replace existing filters.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'unknown' record from different messages correctly with NDEFScanOptions' recordType is set to 'unknown'.: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/NDEFMessage_constructor.https.html
NDEFMessage constructor with a text record: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage constructor with null init dict: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage constructor without init dict: FAIL (Chrome: PASS, Safari: FAIL)
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aaf199008942
https://hg.mozilla.org/mozilla-central/rev/1e40e1d1e544
Description
•