1599693 - Search using <search engine set as default>" tooltip is not shown on search bar

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Alin Ilea, Desktop Test Engineering]

Affected versions:

Nightly 72.0a1 (2019-11-26), Beta 71.

Affected platforms:

Windows 7, Windows 10, Ubuntu 16, Mac OS 10.15

Steps:

1. Launch Firefox and enable the search bar from about:preferences#search by clicking on "Add search bar in toolbar" option.
2. Hover the mouse over the Search Bar.

Actual result:

"Search using <search engine set as default>" is not shown as tooltip.

Expected result:

"Search using <search engine set as default>" tooltip should be displayed.

Regression range:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=04da00a61c6df437250e3af0d20f8ec72bbe9f48&tochange=9596d7f4a7457bccc78cadf9c39bcc9c4b5b97f8

Comment 1

[Mark Banner (:standard8)]

Looks like this was most likely caused by bug 1534455.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1599693 - Fix 'Search using <engine name>' tooltip on the search bar. r?ntim.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e4f4e3cb56d
Fix 'Search using <engine name>' tooltip on the search bar. r=ntim.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9e4f4e3cb56d

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 9113215 [details]
Bug 1599693 - Fix 'Search using <engine name>' tooltip on the search bar. r?ntim.

Beta/Release Uplift Approval Request

• User impact if declined: Missing tooltip for searchbar, which also isn't great for screen reader users.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): straightforward JS patch
• String changes made/needed: none

Comment 6

[Alin Ilea, Desktop Test Engineering]

Verified - fixed on latest Nightly 73.0a1 (2019-12-03) (Build id: 20191203215345) on Mac OS 10.14 , Windows 10 and Ubuntu 18.04

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9113215 [details]
Bug 1599693 - Fix 'Search using <engine name>' tooltip on the search bar. r?ntim.

simple fix for a recent regression, approved for 72.0b3

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/afdb2a315dca

Comment 9

[Alin Ilea, Desktop Test Engineering]

Verified - fixed on latest Beta 72.0b3 (Build id: 20191204104712) on Mac OS 10.14 , Windows 10 and Ubuntu 18.04

Comment 10

[Liz Henry (:lizzard)]

Adding this to list of possible ride-alongs in case we have a dot release driver.

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9113215 [details]
Bug 1599693 - Fix 'Search using <engine name>' tooltip on the search bar. r?ntim.

This is probably not happening now we're getting close to holidays with 72 right after.