1599697 - Keyword input text size in preferences And Edit folder name in New Bookmark arrow panel becomes small when editing

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P2)

Description

[Alice0775 White]

Attachment: screenshot 72.0a1 vs 70.0.1

Reproducible: always

Steps to reproduce:

1. Input keyword for keyword searcgh
   Open about:preferences#search
   Double click on keyword field of search engine list
   Type something

Actual Results:
Text size is small
See attached screenshot

Expected Results:
The text size should be same as the engine name

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a3b08d489762b7c6ca74353b057828e67c22d694&tochange=d7acae5ca73ad308c72adf11baf299e73df4eb3f

Comment 1

[Alice0775 White]

Attachment: image.png

Edit Bookmarks is also affected.

Str:
Add new folder
Edit the folder name

Comment 2

[Tim Nguyen :ntim]

I can see how bug 1581929 could have regressed the tree input, but I can't really see how it regressed the bookmarks popup.

Alice0775, do you get the same regression range for the bookmarks popup ?

Comment 3

[Tim Nguyen :ntim]

Oh nevermind, this is about the bookmarks tree in the bookmarks popup, which could potentially have had the same regression range.

Comment 4

[Tim Nguyen :ntim]

Dão, this is happening because global.css is not imported in the tree shadow root (which is where the relevant input is at). Should I import global.css into the tree shadow root or should I simply re-add the font: inherit rule in tree.css?

Comment 5

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen :ntim from comment #4)

Should I import global.css into the tree shadow root

I don't know, do we normally do this for shadow roots?

or should I simply re-add the font: inherit rule in tree.css?

This seems like an okay option.

Comment 6

[Tim Nguyen :ntim]

(In reply to Dão Gottwald [::dao] from comment #5)

(In reply to Tim Nguyen :ntim from comment #4)

Should I import global.css into the tree shadow root

I don't know, do we normally do this for shadow roots?

There are 3 widgets where we do this: https://searchfox.org/mozilla-central/search?q=global.css&case=false&regexp=false&path=%2Fwidgets

In other widgets, we import widgets.css (which is also imported by global.css).

Importing global.css means we also have to override the default input margin that global.css sets.

I'm going to go with the second solution, since it's less risky (since there might be other global.css stuff to override).

Comment 7

[Tim Nguyen :ntim]

Attachment: Bug 1599697 - Re-add 'font: inherit' to .tree-input. r=dao

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef451aac4c0f
Re-add 'font: inherit' to .tree-input. r=dao

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 9111917 [details]
Bug 1599697 - Re-add 'font: inherit' to .tree-input. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Smaller font-sizes in tree inputs. (see comment 0 and 1)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1 line low-risk CSS fix
• String changes made/needed: no

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ef451aac4c0f

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9111917 [details]
Bug 1599697 - Re-add 'font: inherit' to .tree-input. r=dao

It's a fix for a minor visual issue and it just landed, I am not taking it for RC2 but I am keeping the request open as a potential ridealong of we have a dot release.

Comment 12

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9111917 [details]
Bug 1599697 - Re-add 'font: inherit' to .tree-input. r=dao

we're a week from 72, so this is wontfix for 71.