1599731 - Remove callback support in webconsole attachConsole* test helpers

Status: RESOLVED FIXED

(DevTools :: Console, task, P3)

Description

[Julian Descottes [:jdescottes]]

Small cleanup bug spotted during the review of Bug 1589334.

The three attachConsole helpers defined at https://searchfox.org/mozilla-central/rev/cce8b90aece0f42e5025e45282de16066eeaa662/devtools/shared/webconsole/test/common.js#38-58 support both a callback API and a promise API.

We should be able to migrate all the callback call sites to use promises instead and simplify the implementation.

Call sites: https://searchfox.org/mozilla-central/search?q=attachConsole&path=devtools%2Fshared%2Fwebconsole%2Ftest%2F

Note that this will probably force us to rewrite a few tests using async/await.

Comment 1

[Julian Descottes [:jdescottes]]

Marco proposed to work on this bug on Slack, so assigning it now.

I know you have already fixed several bugs here, but just in case, we have some DevTools focused contributor docs at https://docs.firefox-dev.tools/
Don't hesitate to ping us if you have any question!

Comment 2

[Patrick Brosset <:pbro>]

Hi Marco! Are you still interested in working on this bug? Need any help at all? If so, please shout and we'll make sure to give you all of the necessary pointers to get started with it.

Comment 3

[jpmohr]

I would like to take a crack at this one. It would be my first contribution.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Hello jpmohr, thanks for offering help!

If it's your first bug, you might want to read this https://docs.firefox-dev.tools/getting-started/ to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)
Also, you can come and chat on our Slack https://devtools-html-slack.herokuapp.com/

Let us know if you have any question!

Comment 5

[jpmohr]

Attachment: Bug 1599731 - Remove callbacks from webconsole attach test helpers. r=nchevobbe

Comment 6

[jpmohr]

Attachment: Bug 1599731 - Remove callbacks from webconsole attach test helpers. Address revision issues: style improvements. r=nchevobbe

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1120bd96bf1
Remove callbacks from webconsole attach test helpers. Address revision issues: style improvements. r=nchevobbe

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e1120bd96bf1