1599762 - Add filtering and sorting by score to ASRouterTargeting.jsm

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Kate Hudson :k88hudson]

Manual test steps:

1. Enable ASRouter devtools
2. Set browser.messaging-system.personalized-cfr.scores to {"PDF_URL_FFX_SEND ": 5000}
3. Set browser.newtabpage.activity-stream.asrouter.providers.cfr to {"id":"cfr","enabled":true,"type":"remote-settings","bucket":"cfr","frequency":{"custom":[{"period":"daily","cap":1}]},"categories":["cfrAddons","cfrFeatures"],"updateCycleInMs":3600000,"personalized":true,"personalizedModelVersion": 123}
4. Check devtools. Ensure PDF_URL_FFX_SEND has a score of 5000 and a personalizedModelVersion of 123
5. Ensure you can trigger the PDF URL SEND cfr organically.
6. Reset impressions for CFR by toggling provider pref in devtools.
7. Change browser.messaging-system.personalized-cfr.scores to {"PDF_URL_FFX_SEND ": 4999}
8. Update the modelVersion in the CFR provider pref to 12345, make sure that is reflected in message value in devtools.
9. Make sure that you cannot trigger the PDF URL SEND cfr organically anymore (since it is below the the threshold).

Comment 1

[Kate Hudson :k88hudson]

Note that reading score/model version is already possible via devtools JSON.

Comment 2

[Kate Hudson :k88hudson]

Attachment: Bug 1599762 - Add filtering and sorting by score to ASRouterTargeting

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13b3c5446a59
Add filtering and sorting by score to ASRouterTargeting r=andreio

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/13b3c5446a59

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

I have verified this issue with the steps provided in comment 0 using Latest Firefox Nightly 73.0a1 (Build ID: 20191211094640) on Windows 10 x64, Ubuntu Linux 18.04, and macOS 10.15.1. When the score is below 5000 threshold, the PDF URL SEND cannot be triggered organically, whilst when the score is equal to or higher than 5000 the PDF URL SEND can be triggered organically.