Open Bug 1599807 Opened 6 years ago Updated 5 years ago

Enable captive portal detection code for Talos tests

Categories

(Testing :: Talos, task, P3)

Product:
Testing
Component:
Talos
Version:
Version 3
Type:
task

Tracking

(Not tracked)

People

(Reporter: mconley, Unassigned)

Details

User Story

See here for information on how to contribute: https://wiki.mozilla.org/TestEngineering/Performance/NewContributors

The captive portal detection code seems to be disabled if xre::AreNonLocalConnectionsDisabled here: https://searchfox.org/mozilla-central/rev/cce8b90aece0f42e5025e45282de16066eeaa662/netwerk/base/CaptivePortalService.cpp#149-152

I believe this means that a certain amount of machinery is getting skipped during startup, which affects the realism of our tests.

I suggest we let the captive portal service run in Talos, but have it ping a local server for the connectivity check. I believe this can be done by setting the captivedetect.canonicalURL pref to something local that returns "success" as its response body.

Priority: -- → P2
User Story: (updated)

:mconley, would you be able to be a mentor for this bug?

Flags: needinfo?(mconley)

I'm afraid I'm probably not the best person to do that - especially since I believe there's an active attempt to transition most of these tests away from Talos to mozperftest.

Flags: needinfo?(mconley)
Severity: normal → S3
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.