Closed Bug 1599944 Opened 5 years ago Closed 5 years ago

ubuntu1804 - editor/libeditor/tests/test_bug681229.html | Timed out while polling clipboard for pasted data, got: a

Categories

(Core :: DOM: Editor, defect, P5)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: masayuki)

References

Details

Attachments

(1 file)

Bug 1599944 - Make `SimpleTest.waitForClipboard()` and `SimpleTest.promiseClipboardChange()` relax to compare clipboard data with expected string r=smaug!
47 bytes, text/x-phabricator-request
Details | Review

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=278536353&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/M3iHYB-dQqibGUCmlUcQ8A/runs/0/artifacts/public/logs/live_backing.log

suite: mochitest
chunk: 4

context:
[task 2019-11-27T23:49:51.479Z] 23:49:51 INFO - TEST-START | editor/libeditor/tests/test_bug681229.html
[task 2019-11-27T23:49:56.602Z] 23:49:56 INFO - TEST-INFO | started process screentopng
[task 2019-11-27T23:49:57.011Z] 23:49:57 INFO - TEST-INFO | screentopng: exit 0
[task 2019-11-27T23:49:57.011Z] 23:49:57 INFO - Buffered messages logged at 23:49:51
[task 2019-11-27T23:49:57.012Z] 23:49:57 INFO - must wait for load
[task 2019-11-27T23:49:57.013Z] 23:49:57 INFO - Buffered messages finished
[task 2019-11-27T23:49:57.014Z] 23:49:57 INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug681229.html | Timed out while polling clipboard for pasted data, got: a
[task 2019-11-27T23:49:57.015Z] 23:49:57 INFO - b
[task 2019-11-27T23:49:57.016Z] 23:49:57 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2019-11-27T23:49:57.017Z] 23:49:57 INFO - putAndVerify@SimpleTest/SimpleTest.js:1015:20
[task 2019-11-27T23:49:57.018Z] 23:49:57 INFO - asyncSimpleTest.promiseClipboardChange@SimpleTest/SimpleTest.js:1026:18
[task 2019-11-27T23:49:57.019Z] 23:49:57 INFO - asyncSimpleTest.waitForClipboard@SimpleTest/SimpleTest.js:959:30
[task 2019-11-27T23:49:57.023Z] 23:49:57 INFO - @editor/libeditor/tests/test_bug681229.html:33:14
[task 2019-11-27T23:49:57.024Z] 23:49:57 INFO - focusedOrLoaded/<@SimpleTest/SimpleTest.js:805:67
[task 2019-11-27T23:49:57.025Z] 23:49:57 INFO - GECKO(5899) | MEMORY STAT | vsize 2612MB | residentFast 184MB | heapAllocated 27MB
[task 2019-11-27T23:49:57.026Z] 23:49:57 INFO - TEST-OK | editor/libeditor/tests/test_bug681229.html | took 5138ms

:ehsan - I see that you added this test file back in 2011. With the ubuntu1804 docker image, I am now seeing a consistent failure.

I noticed that the skip-if = headless manifest condition exists, but otherwise nothing else stands out in the manifest file.
Would it be preferable to resolve whatever is causing the failure, or perhaps mark it to be skipped for ubuntu1804 specifically?

Flags: needinfo?(ehsan)

I don't work on editor any longer, redirecting to Masayuki who is our editor expert now.

Flags: needinfo?(ehsan) → needinfo?(masayuki)

I guess that the clipboard of Ubuntu changes how to treat CRLF and CR. They were treated as-is, but it seems that they are replaced with LF now.

I added this test yesterday, if this does not fail on Ubuntu 1804, my guess is correct.
https://searchfox.org/mozilla-central/rev/42c2ecdc429115c32e6bcb78bf087a228a051044/editor/libeditor/tests/test_textarea_value_not_include_cr.html#37-42

Flags: needinfo?(masayuki)

It appears the failure still remains on ubuntu1804:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=f5136a4bdd3d759b1631b02862c51fec1c766160

[task 2019-12-09T18:44:47.541Z] 18:44:47     INFO - TEST-START | editor/libeditor/tests/test_bug681229.html
[task 2019-12-09T18:44:52.681Z] 18:44:52     INFO - TEST-INFO | started process screentopng
[task 2019-12-09T18:44:52.926Z] 18:44:52     INFO - TEST-INFO | screentopng: exit 0
[task 2019-12-09T18:44:52.928Z] 18:44:52     INFO - Buffered messages logged at 18:44:47
[task 2019-12-09T18:44:52.929Z] 18:44:52     INFO - must wait for load
[task 2019-12-09T18:44:52.930Z] 18:44:52     INFO - Buffered messages finished
[task 2019-12-09T18:44:52.931Z] 18:44:52     INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug681229.html | Timed out while polling clipboard for pasted data, got: a
[task 2019-12-09T18:44:52.931Z] 18:44:52     INFO - b 
[task 2019-12-09T18:44:52.932Z] 18:44:52     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2019-12-09T18:44:52.933Z] 18:44:52     INFO -     putAndVerify@SimpleTest/SimpleTest.js:1018:20
[task 2019-12-09T18:44:52.934Z] 18:44:52     INFO -     async*SimpleTest.promiseClipboardChange@SimpleTest/SimpleTest.js:1029:18
[task 2019-12-09T18:44:52.935Z] 18:44:52     INFO -     async*SimpleTest.waitForClipboard@SimpleTest/SimpleTest.js:962:30
[task 2019-12-09T18:44:52.936Z] 18:44:52     INFO -     @editor/libeditor/tests/test_bug681229.html:33:14
[task 2019-12-09T18:44:52.937Z] 18:44:52     INFO -     focusedOrLoaded/<@SimpleTest/SimpleTest.js:808:67
[task 2019-12-09T18:44:52.938Z] 18:44:52     INFO - GECKO(6217) | MEMORY STAT | vsize 2628MB | residentFast 195MB | heapAllocated 23MB
[task 2019-12-09T18:44:52.939Z] 18:44:52     INFO - TEST-OK | editor/libeditor/tests/test_bug681229.html | took 5154ms

I wonder if I need to install some sort of a clipboard package? Since the test environment is a docker image, it could be that a clipboard manager is simply not installed.

I don't think so as I said in comment 11, test_textarea_value_not_include_cr.html does same thing, but it passes in M4. So that, clipboard tests which writes clipboard with linebreakers should be rewritten like my new test.

Understood, I was hoping this was something that I could help deal with by installing a missing package perhaps, but it doesn't look that way.

If it takes the time pressure off, would it be acceptable to have these tests marked either as fail-if or skip-if ubuntu1804?

:masayuki - would it be acceptable to have this test marked as follows while the required parts are being rewritten?

ail-if = (os == 'linux' && os_version == '18.04')

Flags: needinfo?(masayuki)

No, I think that it's should be fixed as I said.

Flags: needinfo?(masayuki)
Assignee: nobody → masayuki
Status: NEW → ASSIGNED

Most tests which use these APIs don't want to distinguish difference of
linebreaks (i.e., CRLF vs. CR vs. LF). And also most tests don't want to
check prefix and postfix of HTML data in clipboard on Windows.

Therefore, this patch makes them compare clipboard data with expected string
smarter. Every linebreak in clipboard data are treated as LF. Expected
HTML data is wrapped with <html>, <body> and comment nodes only on
Windows at comparing with clipboard data.

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/b0699df8b50e Make `SimpleTest.waitForClipboard()` and `SimpleTest.promiseClipboardChange()` relax to compare clipboard data with expected string r=smaug

https://hg.mozilla.org/mozilla-central/rev/b0699df8b50e

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: