1599996 - Master password dialog should be wider

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Dekel Tal]

Attachment: 2019-11-28 11_23_49-Password Required.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Navigated to a page that requires credentials

Actual results:

Since FF is configured to use a master password, I got the "Password Required" popup. It seems there's a regression, where the controls in the popup are misaligned (see attachment). Not sure what changed exactly, but the buttons at the bottom and the password text box seem off.

Comment 1

[Gingerbread Man]

Attachment: Screenshot build 20191128094109.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0
20191128094109

On my system, "password." is now wrapped on a separate line.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cefb0e6f314aa176684e1fce4b71d649ca674c2d&tochange=70b2e0edb9a100ab95af8d7713f99dbc8ebd1ca0

Comment 2

[Tim Nguyen :ntim]

Do you have a screenshot of how it looked like previously ?

Comment 3

[Tim Nguyen :ntim]

Dão, I think this used to "work" thanks to the #filler element which was forcing width: 29em; (which would explain why the text now wraps as comment 1 shows) and with the negative margins set on it . It was making sure the center-aligned dialog buttons (which were outside the grid) looked aligned with the text. I suspect this didn't work well with different locales though.

I can't really test this since macOS isn't affected by this (and aligns its buttons to the right as well), but what do you think of re-introducing a per-platform min-width, something like:

:root {
  min-width: calc(29em - /* value that makes the buttons aligned */);
}

Comment 4

[Gingerbread Man]

Attachment: Screenshot Firefox 70.0.1.png

Comment 5

[Tim Nguyen :ntim]

Thanks! It looks like this wasn't aligned to the input before, so what I said in Comment 3 about the negative margins was wrong. Looks like we do need a min-width however to make it look like it was before.

Comment 6

[Tim Nguyen :ntim]

Attachment: Bug 1599996 - Re-introduce a minimum width to commonDialog.xul. r=dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e14237c29b51
Re-introduce a minimum width to commonDialog.xul. r=dao

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e14237c29b51

Comment 9

[Julien Cristau [:jcristau]]

Backed out for 72.0-build4:
https://hg.mozilla.org/releases/mozilla-release/rev/d2bd57dbd560

Comment 10

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 72.0a1 (2019.11.28) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 73.0b4 on Win 8.1 x64.