Closed
Bug 1600055
Opened 6 years ago
Closed 6 years ago
Get rid of using "outerWindowID" in favor of "browsingContext.id"
Categories
(Remote Protocol :: Agent, task, P1)
Remote Protocol
Agent
Tracking
(firefox74 fixed)
RESOLVED
FIXED
Firefox 74
Tracking | Status | |
---|---|---|
firefox74 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [puppeteer-beta-mvp])
Attachments
(1 file)
Currently we still use the outerWindowId
to reference frames. As we know for each process switch the id will change, and as such invalidates references for clients. To be Fission compatible we will have to purely make use of browsingContext.id
.
Assignee | ||
Comment 1•6 years ago
|
||
It would be good to actually already get this done before starting the work on JSWindowActor (bug 1565162).
Blocks: 1565162
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Comment 2•6 years ago
|
||
Cases where outerWindowID
is used:
https://searchfox.org/mozilla-central/search?q=outerWindowID&path=remote%2F
Summary: Get rid of using "outerWindowId" in favor of "browsingContext.id" → Get rid of using "outerWindowID" in favor of "browsingContext.id"
Updated•6 years ago
|
Priority: P3 → P2
Whiteboard: [puppeteer-beta-mvp]
Assignee | ||
Comment 3•6 years ago
|
||
To pave the way for Fission I'm going to take this up now.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [puppeteer-beta-mvp] → [puppeteer-beta]
Updated•6 years ago
|
Whiteboard: [puppeteer-beta] → [puppeteer-beta-mvp]
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0320f52f97bb
[remote] Switch from using "outerWindowID" to "browsingContext.id". r=remote-protocol-reviewers,ato
Comment 7•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in
before you can comment on or make changes to this bug.
Description
•