1600078 - Move test_alert_unsupported_operation out of WPT

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P1)

Description

[Andreas Tolfsen ❲:ato❳]

The test_alert_unsupported_operation test in testing/web-platform/tests/webdriver/tests/send_alert_text/send.py is Firefox-specific because basic auth prompts are not part of HTML’s definition of user prompts.

We should move the test to testing/web-platform/mozilla/ so that we can continue testing this Gecko-specific behaviour.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1600078: webdriver: make test_alert_unsupported_operation Gecko specific;

Basic auth dialogues are not included in HTML's definition of
'user prompts': those are limited to the 'simple dialogues' such
as window.alert(), window.prompt() et al. and the print dialogue.

Since we don't want to regress this behaviour in geckodriver, this
patch removes test_alert_unsupported_operation from WPT and makes
it Mozilla-specific.

The patch doesn't remove the basic auth framework code from WPT
because it's assumed we will need that in WPT in the very near future.

Thanks-to: Carlos Garcia Campos <[e-mail]>

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1600078: marionette: dismiss unsupported dialogues

test_alert_unsupported_operation relied on the user prompt handler
in the subsequent test to close the basic auth dialogue, which only
incidentally worked because the next WebDriver command was one that
invoked it.

We should dismiss the dialogue and return control to the user when
Marionette encounters an unsupported dialogue type.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c449c7ab372d
webdriver: make test_alert_unsupported_operation Gecko specific; r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/3c08edf74d03
marionette: dismiss unsupported dialogues r=marionette-reviewers,whimboo

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20594 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c449c7ab372d
https://hg.mozilla.org/mozilla-central/rev/3c08edf74d03

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot