Closed Bug 1600122 Opened 1 year ago Closed 1 year ago

"ExtensionSettings" in policies.json does not allow users to disable addons

Categories

(Firefox :: Enterprise Policies, defect, P1)

68 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 73
Tracking Status
firefox-esr68 --- verified
firefox71 --- wontfix
firefox72 --- verified
firefox73 --- verified

People

(Reporter: oliver, Assigned: mkaply)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

We are trying to roll out an extension to a few thousand users on Firefox 68.2 ESR (Linux). I would like to use the policies.json way and the option "ExtensionSettings".

The extension gets installed, but a user is not able to disable it. Every time firefox is installed, the Addon is enabled again.

$ cat /usr/lib64/firefox/distribution/policies.json
{
"policies": {
"ExtensionSettings": {
"ADDONNAME":{
"installation_mode": "normal_installed",
"install_url": "URL to xpi"
}
}
}
}

Actual results:

When using the /usr/lib64/firefox/distribution/policies.json file above, the user is no longer able to disable the Addon, however [0] states that this should be possible. Every time you restart Firefox, the Addon is enabled again.

[0] https://github.com/mozilla/policy-templates#extensionupdate

Expected results:

The Addon should stay disabled if the user disabled it in the Addon settings

Component: Untriaged → Enterprise Policies

quick reproducer with the example from [0]

cat /usr/lib64/firefox/distribution/policies.json
{
  "policies": {
    "ExtensionSettings": {
      "uBlock0@raymondhill.net": {
        "installation_mode": "normal_installed",
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi"
      }
    }
  }
}

adding this to /usr/lib64/firefox/distribution/policies.json installs uBlock, and if the user is disabling the Addon, iti s enabled aain after restart of firefox

[0] https://github.com/mozilla/policy-templates#extensionupdate

double-checked, and the behaviour is the same on mac OS 10.15.1 with Firefox 68.2.0ESR as on Linux

Assignee: nobody → mozilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/d8b0a5b0a5af
Use the complete list of addons for determing policy. r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73

Thanks for the fix. Any chance this will be backported to Firefox 68 ESR?

Thanks for the fix. Any chance this will be backported to Firefox 68 ESR?

Yep. Once it's baked a few days, I'll request uplift.

Comment on attachment 9113323 [details]
Bug 1600122 - Use the complete list of addons for determing policy. r?mixedpuppy

Beta/Release Uplift Approval Request

  • User impact if declined: Extensions can't be disabled by users if they were installed via policy.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Outlined in bug
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Policy only, verified doesn't break existing automated tests
  • String changes made/needed:

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy related
  • User impact if declined: Extensions can't be disabled by users if they were installed via policy.
  • Fix Landed on Version: 73
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Policy only, verified doesn't break existing automated tests
  • String or UUID changes made by this patch:
Attachment #9113323 - Flags: approval-mozilla-esr68?
Attachment #9113323 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9113323 [details]
Bug 1600122 - Use the complete list of addons for determing policy. r?mixedpuppy

policies fix, approved for 72.0b8

Attachment #9113323 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hey Mike,

any news on the uplift for fixing it in RHEL 68ESR? I would need the fix to go forward with my Add-on distribution project.

Thanks
Oliver

any news on the uplift for fixing it in RHEL 68ESR? I would need the fix to go forward with my Add-on distribution project.

I've asked for approval for getting this into the ESR.

Verified as fixed on the latest Nightly 73.0a1 - the extension installed via policy remains disabled after restarting Firefox. Verified on Mac OS X 10.15, Ubuntu 18.04 and Windows 10 x64.

Verified as fixed on Firefox 72 beta 8 on Windows 10, Ubuntu 18.04 and Mac OS X 10.15.

Comment on attachment 9113323 [details]
Bug 1600122 - Use the complete list of addons for determing policy. r?mixedpuppy

Enterprise policy update, approved for 68.4esr.

Attachment #9113323 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

Verified as fixed also on Firefox 64.4.0 esr (used a build from treeherder) on Windows 10 x64, Ubuntu 18.04 and Mac OS X 10.15.

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.