1600122 - "ExtensionSettings" in policies.json does not allow users to disable addons

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[Oliver]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

We are trying to roll out an extension to a few thousand users on Firefox 68.2 ESR (Linux). I would like to use the policies.json way and the option "ExtensionSettings".

The extension gets installed, but a user is not able to disable it. Every time firefox is installed, the Addon is enabled again.

$ cat /usr/lib64/firefox/distribution/policies.json
{
"policies": {
"ExtensionSettings": {
"ADDONNAME":{
"installation_mode": "normal_installed",
"install_url": "URL to xpi"
}
}
}
}

Actual results:

When using the /usr/lib64/firefox/distribution/policies.json file above, the user is no longer able to disable the Addon, however [0] states that this should be possible. Every time you restart Firefox, the Addon is enabled again.

[0] https://github.com/mozilla/policy-templates#extensionupdate

Expected results:

The Addon should stay disabled if the user disabled it in the Addon settings

Comment 1

[Oliver]

quick reproducer with the example from [0]

cat /usr/lib64/firefox/distribution/policies.json
{
  "policies": {
    "ExtensionSettings": {
      "[e-mail]": {
        "installation_mode": "normal_installed",
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi"
      }
    }
  }
}

adding this to /usr/lib64/firefox/distribution/policies.json installs uBlock, and if the user is disabling the Addon, iti s enabled aain after restart of firefox

[0] https://github.com/mozilla/policy-templates#extensionupdate

Comment 2

[Oliver]

double-checked, and the behaviour is the same on mac OS 10.15.1 with Firefox 68.2.0ESR as on Linux

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1600122 - Use the complete list of addons for determing policy. r?mixedpuppy

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8b0a5b0a5af
Use the complete list of addons for determing policy. r=mixedpuppy

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d8b0a5b0a5af

Comment 6

[Oliver]

Thanks for the fix. Any chance this will be backported to Firefox 68 ESR?

Comment 7

[Mike Kaply [:mkaply]]

Thanks for the fix. Any chance this will be backported to Firefox 68 ESR?

Yep. Once it's baked a few days, I'll request uplift.

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 9113323 [details]
Bug 1600122 - Use the complete list of addons for determing policy. r?mixedpuppy

Beta/Release Uplift Approval Request

• User impact if declined: Extensions can't be disabled by users if they were installed via policy.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Outlined in bug
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, verified doesn't break existing automated tests
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy related
• User impact if declined: Extensions can't be disabled by users if they were installed via policy.
• Fix Landed on Version: 73
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, verified doesn't break existing automated tests
• String or UUID changes made by this patch:

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9113323 [details]
Bug 1600122 - Use the complete list of addons for determing policy. r?mixedpuppy

policies fix, approved for 72.0b8

Comment 10

[Oliver]

Hey Mike,

any news on the uplift for fixing it in RHEL 68ESR? I would need the fix to go forward with my Add-on distribution project.

Thanks
Oliver

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c159faaff19

Comment 12

[Mike Kaply [:mkaply]]

any news on the uplift for fixing it in RHEL 68ESR? I would need the fix to go forward with my Add-on distribution project.

I've asked for approval for getting this into the ESR.

Comment 13

[Simona Badau]

Verified as fixed on the latest Nightly 73.0a1 - the extension installed via policy remains disabled after restarting Firefox. Verified on Mac OS X 10.15, Ubuntu 18.04 and Windows 10 x64.

Comment 14

[Simona Badau]

Verified as fixed on Firefox 72 beta 8 on Windows 10, Ubuntu 18.04 and Mac OS X 10.15.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9113323 [details]
Bug 1600122 - Use the complete list of addons for determing policy. r?mixedpuppy

Enterprise policy update, approved for 68.4esr.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/1c6a95c0a0c7

Comment 17

[Simona Badau]

Verified as fixed also on Firefox 64.4.0 esr (used a build from treeherder) on Windows 10 x64, Ubuntu 18.04 and Mac OS X 10.15.