1600137 - moz-phab should warn if two revisions have the same patch id

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement, P2)

Description

[Mitchell Hentges [:mhentges] 🦀]

I performed an hg split for this patch, then was confused when only half my changes were showing up.

It turned out that when I hg split'd, I left the same phabricator patch ID for both commits. So, moz-phab simply updated that patch for each commit, overwriting the first commit with the second.

I think (?) it's always an erroneous if any of the commits being pushed have the same patch ID.

To reproduce

1. Make a commit and send it with moz-phab
2. Do an hg split and split it into two commits
3. Use moz-phab to send both commits
4. moz-phab will update the patch with the first commit, then overwrite the patch with the second commit

Proposed improvement

If any commits being pushed have the same patch ID, immediately warn the user and don't push any commits to Phabricator

Comment 1

[Piotr Zalewa [:zalun]]

This should raise an error.

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1600137 - error if two revisions have the same rev-id