Closed Bug 1600202 Opened 5 years ago Closed 5 years ago

ubuntu1804 - layout/forms/test/test_bug717878_input_scroll.html | overflow scrollTopMax == 0 - didn't expect +0, but got it

Categories

(Core :: Layout: Form Controls, defect, P5)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: MatsPalmgren_bugz)

References

Details

Attachments

(4 files)

Screen Shot 2019-11-29 at 15.55.03.png
249.50 KB, image/png
Details
Screen Shot 2019-11-29 at 15.58.29.png
55.84 KB, image/png
Details
test tweak
2.48 KB, patch
Details | Diff | Splinter Review
Bug 1600202 - Make test_bug717878_input_scroll.html cope with native themes that has a large padding better, and extend the test to also check non-themed controls. r=dbaron
47 bytes, text/x-phabricator-request
Details | Review

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=278675866&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Xt7jSXc5TiGkTx1gcxBceA/runs/0/artifacts/public/logs/live_backing.log

suite: mochitest
chunk: 4

context:
[task 2019-11-28T21:29:30.629Z] 21:29:30 INFO - TEST-START | layout/forms/test/test_bug717878_input_scroll.html
[task 2019-11-28T21:29:30.695Z] 21:29:30 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-28T21:29:30.695Z] 21:29:30 INFO - Buffered messages logged at 21:29:30
[task 2019-11-28T21:29:30.696Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow initial scrollLeft != 0
[task 2019-11-28T21:29:30.696Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow scrollLeftMax != 0
[task 2019-11-28T21:29:30.696Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow able to scroll scrollLeft
[task 2019-11-28T21:29:30.696Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow did not scroll to scrollLeftMax
[task 2019-11-28T21:29:30.697Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow scrolled past scrollLeftMax
[task 2019-11-28T21:29:30.697Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow initial scrollTop != 0
[task 2019-11-28T21:29:30.697Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow scrollTopMax != 0
[task 2019-11-28T21:29:30.698Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow able to scroll scrollTop
[task 2019-11-28T21:29:30.699Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow did not scroll to scrollTopMax
[task 2019-11-28T21:29:30.700Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | no-overflow scrolled past scrollTopMax
[task 2019-11-28T21:29:30.700Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow initial scrollLeft != 0
[task 2019-11-28T21:29:30.700Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow scrollLeftMax == 0
[task 2019-11-28T21:29:30.701Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow unable to scroll scrollLeft
[task 2019-11-28T21:29:30.701Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow did not scroll to scrollLeftMax
[task 2019-11-28T21:29:30.702Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow scrolled past scrollLeftMax
[task 2019-11-28T21:29:30.703Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow initial scrollTop != 0
[task 2019-11-28T21:29:30.703Z] 21:29:30 INFO - Buffered messages finished
[task 2019-11-28T21:29:30.703Z] 21:29:30 INFO - TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug717878_input_scroll.html | overflow scrollTopMax == 0 - didn't expect +0, but got it
[task 2019-11-28T21:29:30.704Z] 21:29:30 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:334:16
[task 2019-11-28T21:29:30.704Z] 21:29:30 INFO - test_scroll@layout/forms/test/test_bug717878_input_scroll.html:52:10
[task 2019-11-28T21:29:30.704Z] 21:29:30 INFO - @layout/forms/test/test_bug717878_input_scroll.html:77:12
[task 2019-11-28T21:29:30.706Z] 21:29:30 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-28T21:29:30.706Z] 21:29:30 INFO - TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug717878_input_scroll.html | overflow unable to scroll scrollTop - didn't expect +0, but got it
[task 2019-11-28T21:29:30.706Z] 21:29:30 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:334:16
[task 2019-11-28T21:29:30.707Z] 21:29:30 INFO - test_scroll@layout/forms/test/test_bug717878_input_scroll.html:59:10
[task 2019-11-28T21:29:30.707Z] 21:29:30 INFO - @layout/forms/test/test_bug717878_input_scroll.html:77:12
[task 2019-11-28T21:29:30.708Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow did not scroll to scrollTopMax
[task 2019-11-28T21:29:30.708Z] 21:29:30 INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow scrolled past scrollTopMax
[task 2019-11-28T21:29:30.724Z] 21:29:30 INFO - GECKO(8734) | MEMORY STAT | vsize 2586MB | residentFast 172MB | heapAllocated 29MB
[task 2019-11-28T21:29:30.727Z] 21:29:30 INFO - TEST-OK | layout/forms/test/test_bug717878_input_scroll.html | took 95ms

:mats - I am sending you a ni because the other engineers are no longer with mozilla.

I am observing this consistent failure when the test is run in the new ubuntu1804 test environment. I am hoping you could redirect the ni to someone that may know about the test, thanks!

Flags: needinfo?(mats)

I'm guessing it's a bug in the test. It has height: 0.5em on the 2nd input, which I assume is too small to fit the default padding/border on this platform. Does the test pass if you add box-sizing: content-box to that element?

Flags: needinfo?(mats) → needinfo?(egao)

:mats - sure thing, I pushed to try with the change. Hope that could fix the issue: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da88643ae22826b00a196052cbd353159dac4a66

Flags: needinfo?(egao)

Perhaps I didn't do it properly, but the test still appears to fail in the push above:

[task 2019-11-29T20:23:32.005Z] 20:23:32     INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow initial scrollTop != 0 
[task 2019-11-29T20:23:32.006Z] 20:23:32     INFO - Buffered messages finished
[task 2019-11-29T20:23:32.007Z] 20:23:32     INFO - TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug717878_input_scroll.html | overflow scrollTopMax == 0 - didn't expect +0, but got it
[task 2019-11-29T20:23:32.007Z] 20:23:32     INFO -     SimpleTest.isnot@SimpleTest/SimpleTest.js:334:16
[task 2019-11-29T20:23:32.008Z] 20:23:32     INFO -     test_scroll@layout/forms/test/test_bug717878_input_scroll.html:53:10
[task 2019-11-29T20:23:32.008Z] 20:23:32     INFO -     @layout/forms/test/test_bug717878_input_scroll.html:78:12
[task 2019-11-29T20:23:32.013Z] 20:23:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-29T20:23:32.014Z] 20:23:32     INFO - TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug717878_input_scroll.html | overflow unable to scroll scrollTop - didn't expect +0, but got it
[task 2019-11-29T20:23:32.014Z] 20:23:32     INFO -     SimpleTest.isnot@SimpleTest/SimpleTest.js:334:16
[task 2019-11-29T20:23:32.015Z] 20:23:32     INFO -     test_scroll@layout/forms/test/test_bug717878_input_scroll.html:60:10
[task 2019-11-29T20:23:32.015Z] 20:23:32     INFO -     @layout/forms/test/test_bug717878_input_scroll.html:78:12
[task 2019-11-29T20:23:32.016Z] 20:23:32     INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow did not scroll to scrollTopMax 
[task 2019-11-29T20:23:32.016Z] 20:23:32     INFO - TEST-PASS | layout/forms/test/test_bug717878_input_scroll.html | overflow scrolled past scrollTopMax 
[task 2019-11-29T20:23:32.017Z] 20:23:32     INFO - GECKO(8679) | MEMORY STAT | vsize 2575MB | residentFast 164MB | heapAllocated 21MB
[task 2019-11-29T20:23:32.020Z] 20:23:32     INFO - TEST-OK | layout/forms/test/test_bug717878_input_scroll.html | took 88ms

Hmm, I don't know what the problem is then. Can you make a screenshot of what this test looks like if you just load the file as is on this platform?

Flags: needinfo?(egao)

This is how it looks like in my ubuntu1804 virtual machine - screenshot attached.

Flags: needinfo?(egao) → needinfo?(mats)

I have the same file side by side.

The top left one is mozilla-central.

The bottom right one is the revision I pushed at https://hg.mozilla.org/try/rev/e5fe07a07748eea9c61fdfc5afd228f91b4a21cc.

Thanks, it looks like there should be vertical overflow in those screenshots... so it's a bit weird that it still fails.
Anyway, I realized that the test also fails on my local system, so I made some changes to the test that makes it pass locally...

Flags: needinfo?(mats)
Attached patch test tweak — — Splinter Review

Can you try this please?

Assignee: nobody → mats
Flags: needinfo?(egao)

Looks like that patch fixes it. mochitest-4 on that Try run has:

[task 2019-11-30T07:05:53.019Z] 07:05:53     INFO - TEST-OK | layout/forms/test/test_bug704049.html | took 108ms
[task 2019-11-30T07:05:53.034Z] 07:05:53     INFO - TEST-START | layout/forms/test/test_bug717878_input_scroll.html
[task 2019-11-30T07:05:53.132Z] 07:05:53     INFO - GECKO(8791) | MEMORY STAT | vsize 2575MB | residentFast 168MB | heapAllocated 23MB
[task 2019-11-30T07:05:53.133Z] 07:05:53     INFO - TEST-OK | layout/forms/test/test_bug717878_input_scroll.html | took 94ms

We should probably just get that patch landed. (I'm happy to review, if you feel like it merits review.)

Flags: needinfo?(mats)
Attachment #9112884 - Attachment description: Bug 1600202 - Make test_bug717878_input_scroll.html cope with native themes that has a large padding better, and extend the test to also check non-themed controls. → Bug 1600202 - Make test_bug717878_input_scroll.html cope with native themes that has a large padding better, and extend the test to also check non-themed controls. r=dbaron
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa04748e12cc Make test_bug717878_input_scroll.html cope with native themes that has a large padding better, and extend the test to also check non-themed controls. r=dbaron

Thanks for the quick turnaround!

https://hg.mozilla.org/mozilla-central/rev/fa04748e12cc

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Flags: needinfo?(MatsPalmgren_bugz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: