1600211 - Handle multipart/x-mixed-replace responses in the parent process

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Matt Woodrow (:mattwoodrow)]

We currently do multipart/x-mixed-replace handling in the content process, which makes it impossible to handle downloadable parts entirely in the parent process (as we'd like to do in bug 1574372).

If we run this in the parent process, we can make a per-part decision on where the direct the content to, and only send content to be displayed down into the content process.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Convert DocumentLoadListener to use a Variant for recording and replaying nsIStreamListener functions. r?mayhemer

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Create a multi-part converter in nsHttpChannel if needed. r?mayhemer

Depends on D55215

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Support passsing nsIMultiPartChannel values through PHttpChannel, and conditionally expose this interface on HttpChannelChild. r?mayhemer

Depends on D55216

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r?mayhemer

Depends on D55217

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r?mayhemer

This also removes OnStartRequestSent from PHttpBackgroundChannel, since there should never be any messages sent earlier on this channel, so we can just assume the waiting state initially.

Depends on D55218

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r?mayhemer

We can't always know when sending a part if it'll be the last one (either because the channel is later cancelled, or because the response just sends the end boundary without warning). This was initially reported in bug 339610.

Depends on D55219

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Support multipart channels in DocumentLoadListener. r?mayhemer

Depends on D55220

Comment 8

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Disable content conversion by HttpChannelChild if we have already applied it by the time we get to HttpChannelParent::OnStartRequest. r?mayhemer

We normally get HttpChannelParent::OnStartRequest directly from nsHttpChannel::OnStartRequest, where we disable content conversion and ask the child to do it instead.

When we install a multipart converter, we defer calling HttpChannelParent::OnStartRequest until we've decoded parts, at which point content conversion is already applied to the stream.

This detects that case, and stops the child trying to do it a second time (which fails, and breaks the content).

Depends on D55221

Comment 9

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1600211 - Forward AllPartsStopped to HttpChannelChild to ensure that we notify the listeners correctly. r?mayhemer

Depends on D55222

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9300f56262d4
Convert DocumentLoadListener to use a Variant for recording and replaying nsIStreamListener functions. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/5caa332c7edb
Create a multi-part converter in nsHttpChannel if needed. r=dragana
https://hg.mozilla.org/integration/autoland/rev/e07c2e552828
Support passsing nsIMultiPartChannel values through PHttpChannel, and conditionally expose this interface on HttpChannelChild. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/1f8f8d00df76
Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/a2ec935602ab
Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/5b4c042c0d18
Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/2d16a3cedb87
Support multipart channels in DocumentLoadListener. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/e4dea7d4d633
Disable content conversion by HttpChannelChild if we have already applied it by the time we get to HttpChannelParent::OnStartRequest. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/1e479194244a
Forward AllPartsStopped to HttpChannelChild to ensure that we notify the listeners correctly. r=mayhemer

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9300f56262d4
https://hg.mozilla.org/mozilla-central/rev/5caa332c7edb
https://hg.mozilla.org/mozilla-central/rev/e07c2e552828
https://hg.mozilla.org/mozilla-central/rev/1f8f8d00df76
https://hg.mozilla.org/mozilla-central/rev/a2ec935602ab
https://hg.mozilla.org/mozilla-central/rev/5b4c042c0d18
https://hg.mozilla.org/mozilla-central/rev/2d16a3cedb87
https://hg.mozilla.org/mozilla-central/rev/e4dea7d4d633
https://hg.mozilla.org/mozilla-central/rev/1e479194244a