1600251 - mach: error: argument --setpref: expected one argument

Status: NEW

(Testing :: General, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Calling ./mach test with --setpref but not using an equality sign between the option and the value causes the command to fail:

./mach test --setpref "remote.log.level=Debug" remote/test/browser
UNKNOWN TEST: remote.log.level=Debug
usage: mach [options] [test paths]
mach: error: argument --setpref: expected one argument

Comment 1

[Geoff Brown [:gbrown]]

./mach test --setpref="remote.log.level=Debug" remote/test/browser is OK
./mach mochitest --setpref="remote.log.level=Debug" remote/test/browser is OK
./mach mochitest --setpref "remote.log.level=Debug" remote/test/browser is OK

The 'mach test' parameters are quite generic, simply distinguishing 'extra_args' (arguments starting with --) from 'what' (all other args: tests to run), so "--setpref <pref-arg> <test>" is parsed as extra_args='--setpref', what=['<pref-arg>', '<test>'].

I expect the same issue for any command (not global) option that takes a parameter, used with 'mach test'.