1600325 - Nothing happens when the “Okay, Got It” button from the “Redirect” tip is focused and the "Enter" key is pressed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: keyboard navigation.gif

[Affected versions]:

• Latest Firefox Nightly 72.0a1 (Build ID: 20191128214853)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 16.04 x64

[Prerequisites]:

• Have the latest Nightly installed.
• Have the “devtools.chrome.enabled” pref set to “true”.
• Run the “(async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })();” code on the browser console.
• Have access to the stage delivery console.
• Have an active branched add-on recipe.
• Have the “security.content.signature.root_hash” pref set to "DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90".
• Have the "app.normandy.api_url" pref set to "https://stage.normandy.nonprod.cloudops.mozgcp.net/api/v1".
• Have the "app.normandy.dev_mode" pref set to “true”.
• Have the "app.normandy.logging.level" pref set to “0”.
• Have the "services.settings.server" pref set to "https://settings.stage.mozaws.net/v1".
• Have the "xpinstall.signatures.dev-root" pref set to “true”.
• Create a new pref named “carmentips” and set it as “true”.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to the “www.google.com” page.
3. Press the “Tab” key until the “Okay, Got It” button is focused.
4. Press the “Enter” key and observe what happens next.

[Expected result]:

• The “Redirect” tip is dismissed.

[Actual result]:

• The “Redirect” tip is still displayed.

[Notes]:

• This issue is not reproducible with the “Onboarding” tip.
• Attached a screen recording with the issue.

Comment 1

[Drew Willcoxon :adw]

I investigated this but I'm not sure what's going on yet. I have a couple of questions: (1) Why is the button focused (since it's just a span)? (2) Why isn't the urlbar focused instead?

The answers seem to be related to the role=button attribute on the button. When I remove that, the urlbar is focused instead as expected. I thought that's just for a11y but it must affect focus, too. We can't remove it, so I'm not sure how to work around this. Adding -moz-user-focus: ignore doesn't help.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1600325 - When tip buttons receive focus, focus the input instead.

Instead of trying to prevent the tip buttons from being focused in the first place, we can just listen for focus on the parent tip element and focus the input instead.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/028ed80e060a
When tip buttons receive focus, focus the input instead. r=mak

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/028ed80e060a

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9113107 [details]
Bug 1600325 - When tip buttons receive focus, focus the input instead.

Beta/Release Uplift Approval Request

• User impact if declined: We need this in order to run the urlbar nudges and interventions experiments (bug 1568594, bug 1564506) on 72 as planned.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is small and only affects urlbar "tip" results, which are not normally shown and will currently be shown only in experiments. We also have QA coverage for this due to the experiments. Please note that I chose "yes" for the question about whether this code is covered by automated tests -- we have automated test coverage for tip results in general but not for this specific bug. Manual QA coverage is enough for this.
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9113107 [details]
Bug 1600325 - When tip buttons receive focus, focus the input instead.

one-line urlbar fix for experiments, approved for 72.0b3

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 73.0a1 (Build ID: 20191204215924) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The "Redirect" tip is dismissed when it's focused and the "Enter" key is pressed.

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/db346c3676c2

Comment 9

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello Simona,

Will you also cover this issue in 72.0b3?

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue and is no longer reproducible on the Firefox Beta 72.0b3 Unbranded build (Build ID: 20191205201734) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The "Redirect" tip is dismissed when it's focused and the "Enter" key is pressed.