1600335 - Add histogram entry for the amount of time spent processing messages

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Andrei Oprea [:andreio]]

TelemetryStopwatch allows to start/stop timers to count time spent filtering for unblocked messages and evaluating targeting.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1600335 - Add histogram entry for the amount of time spent processing messages

Comment 2

[Andrei Oprea [:andreio]]

Attachment: data-review.txt

Comment 3

[Chris H-C :chutten]

Comment on attachment 9113529 [details]
data-review.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :aoprea is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd309e6f07be
Add histogram entry for the amount of time spent processing messages r=k88hudson

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bd309e6f07be

Comment 6

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue on Latest Firefox Nightly 73.0a1 (Build ID: 20191211214629) on Windows 10 x64, Mac 10.14.6 and Arch Linux 3.34.1.
The MS_MESSAGE_REQUEST_TIME_MS telemetry ping is displayed in the "about:telemetry" page in the Histograms section, and the value of the ping changes after seeing the "about:newtab" page, the "about:welcome" page, a CFR recommendation, the "What's New Panel" or when navigating to certain website which trigger a message.