1600490 - FTP listings show "File:" alt text instead of icon

Status: RESOLVED WONTFIX

(Core Graveyard :: Networking: FTP, defect)

Description

[Arnaud]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Browse FTP site.

Actual results:

The file icon is broken since a few versions. Firefox display "File: " text instead.

Expected results:

An icon of a blank page of paper with a corner creased should be displayed.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0
20191130213831

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ea747bb2ffb77d1fd62b5fa6217cbee15b73d31f&tochange=781485c695e1f07b8782427d556f6570e4a8072f

mozregression-gui can't narrow the range further because this regression is about 2 years old. Still, bug 1222924 looks like the prime suspect because this is what Inspector shows:
<img src="moz-icon://.zip?size=16" alt="File:">

Comment 2

[Arnaud]

Indeed. moz-icon is surely the problem here as every file type icons from the view depends on it.
The folder picture works as it does not depends on it, but from the chrome skin.
I don't know where moz-icon collection should be located, but I think embedded icons as resources is the solution to avoid such (not very important, but highly unpleasant) problem.
Hope it can be solved this way.
Regards.

Comment 3

[:Gijs (he/him)]

Breaking app/filetype-specific icons was kind of an explicit decision. See https://bugzilla.mozilla.org/show_bug.cgi?id=1222924#c6 (quoting the relevant bit of comment #5) and comment 7.

I think if we care about FTP we can fix the icons for the file listing. But I'm pretty sure we're going to be removing support eventually, so I don't know how much of a priority fixing this will be.

Comment 4

[Darkspirit]

This regression is 2 years old and was basically intended. Insecure ftp:// is dead.
(bug 1593595 comment 2 has tips for ftps:// with vsftpd+FileZilla (bug 85464) and https:// directory listing with nginx (bug 1574475). The best we all can do is sending ftp server operators a short email asking them for switching to https.)