Closed Bug 1600544 Opened 5 years ago Closed 5 months ago

Spam a once-per-document console warning when we notice grid items that are XUL content

Categories

(Core :: Layout: Grid, task, P3)

task

Tracking

()

RESOLVED WONTFIX

People

(Reporter: dholbert, Unassigned)

References

Details

We've got some CSS grid in our frontend with XUL content as some of its grid items, and we'd like to discourage that pattern from spreading (or at least be wary of it spreading).

Mats suggests in review in bug 1593060 that we should spam a once-per-document warning about this, to notify our frontend developers if they happen to introduce more of these. Seems like a good idea.

Not just for detecting new ones, but also making existing ones visible. Here's the warning I was thinking about:
https://searchfox.org/mozilla-central/rev/073b138dcba41cd3f858522e5f0a9ee73e39afa0/dom/base/Document.cpp#11953
The call should probably be "#ifdef NIGHTLY" though.

Severity: normal → S3

The patch in bug 1593060 has been reverted in bug 1870983, and we no longer have grid items that ware XUL. Let's close this.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.