1600599 - Code coverage link in Other Tools is broken when a line is selected

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/frame.js#53
• click on "Code Coverage"

The page navigates to https://coverage.moz.tools/#revision=latest&path=devtools/server/actors/targets/frame.js&view=file#53 which shows Invalid view : file#53.

The link should be https://coverage.moz.tools/#revision=latest&path=devtools/server/actors/targets/frame.js&view=file&line=53 (#53 -> &line=53)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

This should be pretty easy to fix.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: GitHub Pull Request

Comment 3

[Emilio Cobos Álvarez [:emilio]]

It works now, but there's a gotcha, which is that file lines in the coverage link are zero-indexed, which means that we always go to the next line... Marco, I think lines being zero-indexed is pretty weird, maybe that could be fixed in coverage.moz.tools?

Comment 4

[Marco Castelluccio [:marco]]

Yes, I've filed https://github.com/mozilla/code-coverage/issues/316.