1600619 - Closing developer tools switches focus back to the original tab

Status: VERIFIED FIXED

(DevTools :: Console, defect, P3)

Description

[exuvo]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Open developer tools in separate window for a tab.
Switch tab.
Click close window button on the developer tools window.

Actual results:

Developer tab is closed but the current tab is also changed to the tab the dev tool window was connected to. Not needed when I am closing an old dev tools window.

Expected results:

Developer tab is closed and my current tab remains active.

Not sure when this bug was introduced, as no other interaction with the dev tools seem to select the related tab, where it might actually be useful.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0
20191202091209

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2a53b590e435e4d2667444b1dca4507afa9990eb&tochange=150bf969aea0ec4434daccd86c52cc96f0f3c02a

(In reply to exuvo from comment #0)

Not sure when this bug was introduced

For future reference, you can use mozregression-gui to find out.

• https://mozilla.github.io/mozregression/quickstart.html

Comment 2

[Gingerbread Man]

:nchevobbe it's been a month and a half with no response from the author of the regressing patch. I see a current total of 17 needinfo requests with the oldest dating back to 2017. Should someone else take a look at this bug report?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Gingerbread Man from comment #2)

:nchevobbe it's been a month and a half with no response from the author of the regressing patch. I see a current total of 17 needinfo requests with the oldest dating back to 2017. Should someone else take a look at this bug report?

We're all very busy and we have to prioritize what we do from our days, so please acknowledge that.
I'll try to have a look at this issue.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1600619 - Don't focus the content page when closing the console when the tab it was opened for is now inactive. r=ochameau.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Tried something (see Comment 4) using docShell.isActive which seemed promising from manually testing, but isn't picked up by the new test I added.
Not sure if this is a test-env related thing, or if it's highlighting a race condition in my solution for now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e46a5f7f16
Don't focus the content page when closing the console when the tab it was opened for is now inactive. r=ochameau.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a8e46a5f7f16

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval if you're comfortable doing so.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

sure, let me do that

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9121553 [details]
Bug 1600619 - Don't focus the content page when closing the console when the tab it was opened for is now inactive. r=ochameau.

Beta/Release Uplift Approval Request

• User impact if declined: If the user opened devtools in a separate window, switched to another tab and then closed the devtools window, the previous tab will be selected, which can be annoying.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open devtools

1. From the meatball menu, select "separate window"
2. Switch to another tab
3. Close the devtools window

ER: The selected tab shouldn't change

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): devtools only, covered by test
• String changes made/needed:

Comment 11

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue using Beta version 74.0b2 (Build id: 20200211200559).
Verified - Fixed in latest Nightly 75.0a1 (Build id: 20200212205745) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9121553 [details]
Bug 1600619 - Don't focus the content page when closing the console when the tab it was opened for is now inactive. r=ochameau.

Covered by tests and verified on Nightly by QA, , uplift approved for 74.0b3, thanks.

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d9151b034fe8

Comment 14

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta 74.0b3 (Build id: 20200214015126) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.