Closed Bug 1600624 Opened 5 years ago Closed 5 years ago

Intermittent Assertion failure: aSheet->GetOwnerRule(), at z:/build/build/src/layout/style/StyleSheet.cpp:614

Categories

(Core :: CSS Parsing and Computation, defect, P5)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox-esr68 --- wontfix
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: emilio)

References

Details

(Keywords: assertion, intermittent-failure)

Attachments

(2 files)

Bug 1600624 - Fix import rules to properly unlink their stylesheet from its parent. r=heycam
47 bytes, text/x-phabricator-request
Details | Review
Bug 1600624 - Make the StyleSheet children setup simpler. r=heycam
47 bytes, text/x-phabricator-request
Details | Review

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=279037474&repo=mozilla-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/O8b6ItpLSPi1KO9QlMh3Sw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/O8b6ItpLSPi1KO9QlMh3Sw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2019-12-02T13:21:11.841Z] 13:21:11 INFO - REFTEST TEST-START | file:///Z:/task_1575287673/build/tests/reftest/tests/layout/reftests/css-import/1373559.html == file:///Z:/task_1575287673/build/tests/reftest/tests/layout/reftests/css-import/1373559-ref.html
[task 2019-12-02T13:21:11.841Z] 13:21:11 INFO - REFTEST TEST-LOAD | file:///Z:/task_1575287673/build/tests/reftest/tests/layout/reftests/css-import/1373559.html | 14 / 15 (93%)
[task 2019-12-02T13:21:11.888Z] 13:21:11 INFO - ++DOMWINDOW == 28 (08BBC400) [pid = 2112] [serial = 45] [outer = 01081160]
[task 2019-12-02T13:21:11.915Z] 13:21:11 INFO - Assertion failure: aSheet->GetOwnerRule(), at z:/build/build/src/layout/style/StyleSheet.cpp:614
[task 2019-12-02T13:21:12.010Z] 13:21:12 INFO - #01: mozilla::css::Loader::SheetComplete(mozilla::css::SheetLoadData &,nsresult) [layout/style/Loader.cpp:1725]
[task 2019-12-02T13:21:12.011Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.011Z] 13:21:12 INFO - #02: static void mozilla::css::Loader::ParseSheet::<unnamed-tag>::operator()(bool) [layout/style/Loader.cpp:1680]
[task 2019-12-02T13:21:12.011Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.012Z] 13:21:12 INFO - #03: void mozilla::MozPromise<bool,bool,1>::ThenValue<lambda at z:/build/build/src/layout/style/Loader.cpp:1670:11',lambda at z:/build/build/src/layout/style/Loader.cpp:1681:11'>::DoResolveOrRejectInternal(class mozilla::MozPromise<bool,bool,1>::ResolveOrRejectValue & const) [xpcom/threads/MozPromise.h:739]
[task 2019-12-02T13:21:12.012Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.012Z] 13:21:12 INFO - #04: mozilla::MozPromise<bool,bool,1>::ThenValueBase::ResolveOrRejectRunnable::Run() [xpcom/threads/MozPromise.h:403]
[task 2019-12-02T13:21:12.013Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.013Z] 13:21:12 INFO - #05: mozilla::SchedulerGroup::Runnable::Run() [xpcom/threads/SchedulerGroup.cpp:299]
[task 2019-12-02T13:21:12.013Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.013Z] 13:21:12 INFO - #06: nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:1251]
[task 2019-12-02T13:21:12.013Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.013Z] 13:21:12 INFO - #07: NS_ProcessNextEvent(nsIThread *,bool) [xpcom/threads/nsThreadUtils.cpp:486]
[task 2019-12-02T13:21:12.013Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.014Z] 13:21:12 INFO - #08: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:88]
[task 2019-12-02T13:21:12.014Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.014Z] 13:21:12 INFO - #09: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:316]
[task 2019-12-02T13:21:12.014Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.014Z] 13:21:12 INFO - #10: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:309]
[task 2019-12-02T13:21:12.014Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.014Z] 13:21:12 INFO - #11: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
[task 2019-12-02T13:21:12.015Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.015Z] 13:21:12 INFO - #12: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
[task 2019-12-02T13:21:12.015Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.015Z] 13:21:12 INFO - #13: nsAppShell::Run() [widget/windows/nsAppShell.cpp:406]
[task 2019-12-02T13:21:12.015Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.015Z] 13:21:12 INFO - #14: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:934]
[task 2019-12-02T13:21:12.015Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.016Z] 13:21:12 INFO - #15: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:238]
[task 2019-12-02T13:21:12.016Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.016Z] 13:21:12 INFO - #16: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:316]
[task 2019-12-02T13:21:12.016Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.016Z] 13:21:12 INFO - #17: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:309]
[task 2019-12-02T13:21:12.017Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.017Z] 13:21:12 INFO - #18: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
[task 2019-12-02T13:21:12.017Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.017Z] 13:21:12 INFO - #19: XRE_InitChildProcess(int,char * * const,XREChildData const *) [toolkit/xre/nsEmbedFunctions.cpp:773]
[task 2019-12-02T13:21:12.017Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.018Z] 13:21:12 INFO - #20: mozilla::BootstrapImpl::XRE_InitChildProcess(int,char * * const,XREChildData const *) [toolkit/xre/Bootstrap.cpp:67]
[task 2019-12-02T13:21:12.018Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.018Z] 13:21:12 INFO - #21: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:272]
[task 2019-12-02T13:21:12.018Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.018Z] 13:21:12 INFO - #22: wmain [toolkit/xre/nsWindowsWMain.cpp:131]
[task 2019-12-02T13:21:12.018Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.019Z] 13:21:12 INFO - #23: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:288]
[task 2019-12-02T13:21:12.019Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.019Z] 13:21:12 INFO - #24: kernel32.dll + 0x4ef3c
[task 2019-12-02T13:21:12.019Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.020Z] 13:21:12 INFO - #25: ntdll.dll + 0x63618
[task 2019-12-02T13:21:12.020Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.020Z] 13:21:12 INFO - #26: ntdll.dll + 0x635eb
[task 2019-12-02T13:21:12.020Z] 13:21:12 INFO -
[task 2019-12-02T13:21:12.240Z] 13:21:12 INFO - [Parent 5880, Main Thread] WARNING: IPC message discarded: actor cannot send: file z:/build/build/src/ipc/glue/ProtocolUtils.cpp, line 481
[task 2019-12-02T13:21:12.241Z] 13:21:12 INFO - [Parent 5880, Main Thread] WARNING: IPC message discarded: actor cannot send: file z:/build/build/src/ipc/glue/ProtocolUtils.cpp, line 481
[task 2019-12-02T13:21:12.264Z] 13:21:12 ERROR - A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down

Assignee: nobody → emilio
Flags: needinfo?(emilio)

Test is hopefully self-explanatory. The children setup here is a bit bogus as
noted here and other comments, will file a followup to clean it up.

This is a follow-up which makes me feel better about this whole thing.

Depends on D55550

Attachment #9113052 - Attachment description: Bug 1600624 - Make the StyleSheet children setup simpler and sound. r=heycam → Bug 1600624 - Make the StyleSheet children setup simpler. r=heycam
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3c543e00e2d
Fix import rules to properly unlink their stylesheet from its parent. r=heycam
https://hg.mozilla.org/integration/autoland/rev/1019f8467d74
Make the StyleSheet children setup simpler. r=heycam
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20579 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/d3c543e00e2d
https://hg.mozilla.org/mozilla-central/rev/1019f8467d74

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Upstream PR merged by moz-wptsync-bot

Is there a user impact which would justify Beta backport of these patches or can this ride Fx73 to release?

status-firefox71: --- → wontfix
status-firefox72: --- → affected
status-firefox-esr68: --- → wontfix
Flags: needinfo?(emilio)
Flags: in-testsuite+
Keywords: assertion

We don't look at the rule pointer atm, so I think not. If only some potential perf wins / correctness improvements. But the correctness issue has been there since forever so...

Wouldn't be scary to uplift if the intermittent was frequent in beta though.

Flags: needinfo?(emilio)

This has only hit on Beta once in 2 weeks. Let's just let it ride the trains.

status-firefox72: fix-optional → wontfix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: