Closed Bug 1600661 Opened 6 years ago Closed 6 years ago

Refactor findAllMessage, findMessage into handleMessageRequest

Categories

(Firefox :: Messaging System, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 73
Iteration:
73.1 - Dec 2 - Dec 15
Tracking Status
firefox73 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now we have a lot of duplicated code between findAllMessagesand findMessage as well as findAllMatchingMessages and findMatchingMessage in ASRouterTargeting.jsm

Let's refactor them to only use a single path i.e. go through handleMessageRequest and findMatchingMessage. This will help us consolidate some sorting logic into one place eventually.

Assignee: nobody → khudson
Type: enhancement → task
Iteration: --- → 73.1 - Dec 2 - Dec 15
Priority: -- → P1
Pushed by khudson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8c386d35f88 Refactor findAllMessage findMessage into handleMessageRequest r=andreio
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: