1600692 - Crash in [@ NSSCKFWC_GetAttributeValue | PK11_ReadAttribute]

Status: RESOLVED DUPLICATE of bug 1597799

(Core :: Security: PSM, defect)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-c2f4a13b-1c2c-48ac-91ad-7788b0191120.

Seen while looking at macOS crash stats - this crashes goes back on 72 to 20191116051316: https://bit.ly/2P40SDo. 14 crashes/11 installs while 72 was in nightly.

In the regression range https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1e1617c67238dfb685fb3d07bf1793232c4469fa&tochange=05f4ac2d6dd6beb54482ce138d36cf3226f2464c I do see an NSS update.

Top 10 frames of crashing thread:

0 libnssckbi.dylib NSSCKFWC_GetAttributeValue security/nss/lib/ckfw/wrap.c:2244
1 libnss3.dylib PK11_ReadAttribute security/nss/lib/pk11wrap/pk11obj.c:105
2 libnss3.dylib PK11_FindRawCertsWithSubject security/nss/lib/pk11wrap/pk11obj.c:1971
3 XUL mozilla::psm::NSSCertDBTrustDomain::FindIssuer security/certverifier/NSSCertDBTrustDomain.cpp:256
4 XUL mozilla::pkix::BuildForward security/nss/lib/mozpkix/lib/pkixbuild.cpp:365
5 XUL mozilla::pkix::PathBuildingStep::Check security/nss/lib/mozpkix/lib/pkixbuild.cpp:211
6 XUL mozilla::psm::CheckCandidates security/certverifier/NSSCertDBTrustDomain.cpp:189
7 XUL mozilla::psm::NSSCertDBTrustDomain::FindIssuer security/certverifier/NSSCertDBTrustDomain.cpp:344
8 XUL mozilla::pkix::BuildForward security/nss/lib/mozpkix/lib/pkixbuild.cpp:365
9 XUL mozilla::psm::BuildCertChainForOneKeyUsage security/certverifier/CertVerifier.cpp:239

Comment 1

[J.C. Jones [:jcj] (he/him)]

While the stack is slightly different than 1597799 because of the different platform (Mac vs Windows), it's the same issue. I landed the change to NSS, which will make its way into Beta 72 around EOW.