1600733 - "hg reviewers" should show count of commits for each reviewer

Status: RESOLVED FIXED

(Developer Services :: Mercurial: mozext, defect)

Description

[Mitchell Hentges [:mhentges] 🦀]

As part of 1592429, I simplified the output because it seemed overly verbose and potentially confusing. The "commit count" and "weight" per reviewer was omitted, and instead hg reviewers would just print the order of the first 5 reviewers.

However, after some discussion with :botond, it turns out that the commit count is valuable:

if "A" and "B" are in first and second place, and A is someone who's no longer active on the project but still sometimes does reviews, and B is someone who's active on the project, then I might choose to bother A if the numbers are "A:33, B: 1", but not if they're "A: 33, B:17"

We should format the output to show the commit count, while also making it clear that the number we output is a commit count (probably just formatting the output like a table).

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: mozext: show count of commits for each reviewer (Bug 1600733) r=sheehan

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1600733 - use non-arc implementation by default, adds --arc r?zalun

Depends on D55721

Comment 3

[Phabricator Automation]

Comment on attachment 9113370 [details]
Bug 1600733 - use non-arc implementation by default, adds --arc r?zalun

Revision D55757 was moved to bug 1600696. Setting attachment 9113370 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/febbe743821d
mozext: show count of commits for each reviewer r=sheehan