Switch off objc_exception cargo patch
Categories
(Core :: Graphics, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: kvark, Assigned: kvark)
Details
Attachments
(1 file)
The patch (in our root Cargo.toml section "[patch.crates-io]") was required at the time we had fixes on the way to being upstreamed. Now version 0.1.2 contains what we need, and the branch no longer exists, so the patch need to be removed in order for mach vendor rust to work correctly.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 2•5 years ago
|
||
kvark, if it is not too much trouble, could create a new branch off of master with the same "cc" name until this lands? I am running into the vendoring issue and would rather not get this swept up in my work.
|
|
||
Comment 3•5 years ago
•
|
||
Nevermind, this already landed. I was looking at the wrong tree.
|
|
||
Updated•5 years ago
|
|
|
||
Comment 4•5 years ago
|
||
I would also like to point out that deleting the branch is basically removing the version from history, which hurts reproducible builds.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Nico,
I think the "preserving history" part is not critical in our case, since the source is vendored, and one can always see the difference with the published version if needed.
With that in mind, we should only delete the branch after Gecko's "Cargo.toml" is fixed. It was accidental in this case because I got a habit of cleaning up my branches, and Github UI is very inviting to do this with a single click.
Anyhow, I did restore that branch for the meantime, so that everyone can keep working undisrupted. Will delete it in a few months.
|
|
||
Comment 6•5 years ago
|
||
Thanks, Dzmitry! You are probably right in this case as far as its effect, because it is vendored and frozen. Have a good evening!
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•