Closed
Bug 1600795
Opened 5 years ago
Closed 5 years ago
[jsdbg2] Debugger::wrapNullableDebuggeeObject should exist
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: jimb, Assigned: loganfsmyth)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We have many spots in the code that look like this:
if (!unwrapped) {
result.set(nullptr);
return true;
}
return dbg->wrapDebuggeeObject(cx, unwrapped, result);
It would be much nicer if wrapDebuggeeObject just passed through null, or if there were a variant wrapNullableDebuggeeObject that did so.
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → loganfsmyth
Pushed by loganfsmyth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a22c83382c80
Centralize behavior for returning Debugger.Object or null. r=jimb
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•