Closed Bug 1600847 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 20573 - [ChromeDriver] Workaround DevTools fullscreen issue

Categories

(Testing :: geckodriver, task, P4)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20573 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20573
Details from upstream follow.

John Chen <johnchen@chromium.org> wrote:

[ChromeDriver] Workaround DevTools fullscreen issue

Add some workaround code while setting browser window to fullscreen
mode, to work around an issue in DevTools fullscreen command. In
particular, call document.documentElement.requestFullscreen() to ensure
that document.webkitIsFullScreen returns the correct values. All WPT
tests related to fullscreen now pass.

Also made an adjustment to WPT set_window_rect/set.py
test_fully_exit_fullscreen, which was using a width below the minimum
supported by Chrome.

Bug: 982071
Change-Id: I0e50883c3f67a566df1bc4ffd331aeac0b0ef1e1
Reviewed-on: https://chromium-review.googlesource.com/1947816
WPT-Export-Revision: df4fc4981a0377763173b86f4f8bbb1d89fe1bb2

Component: web-platform-tests → geckodriver

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 70 subtests

Firefox

OK : 1
PASS: 70

Chrome

OK : 1
PASS: 69
FAIL: 1

Safari

OK : 1
PASS: 69
FAIL: 1

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e6b1021a442
[wpt PR 20573] - [ChromeDriver] Workaround DevTools fullscreen issue, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.