1600860 - [Interventions] The extension needs a way to install an update and restart for users who have opted out of automatic updates

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Users can opt out of automatic updates. In that case, when an update is available, we need to let the user download and install it and restart the browser. This case isn't covered in the interventions spec, but it's consistent with the intention to give the user a one-click way to continue on their upgrade path, so I think we should handle it.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1600860 - Add browser.experiments.urlbar.installBrowserUpdateAndRestart.

Users can opt out of automatic updates. In that case, when an update is available, we need to let the user download and install it and restart the browser. This case isn't covered in the interventions spec, but it's consistent with the intention to give the user a one-click way to continue on their upgrade path, so I think we should handle it.

This patch adds a browser.experiments.urlbar.installBrowserUpdateAndRestart function. At first I made it only install the update, and then the extension called our existing restartBrowser function once that finished. But it didn't work because restartBrowser must be called from a user-input handler, and apparently by awaiting the install function, any code running after the await isn't considered to be in the user-input handler.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4906b360798f098cc6fddbd54dd0e8c3525cfee0

Comment 3

[Drew Willcoxon :adw]

I talked with Verdi about this, and he likes it.

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0145b7cde3ccfbe7168fa0274d57ec365aa4c66b

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b959a4f2babf
Add browser.experiments.urlbar.installBrowserUpdateAndRestart. r=mak,mixedpuppy

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b959a4f2babf

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 9113122 [details]
Bug 1600860 - Add browser.experiments.urlbar.installBrowserUpdateAndRestart.

Beta/Release Uplift Approval Request

• User impact if declined: We need this in order to run the urlbar interventions experiment (bug 1564506) on 72 as planned.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1601369 needed to fix intermittent created by this patch
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a test-only change. There's no change to shipping code. This patch causes an intermittent failure that's fixed by bug 1601369, so bug 1601369 should also be uplifted.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9113122 [details]
Bug 1600860 - Add browser.experiments.urlbar.installBrowserUpdateAndRestart.

this is test-only

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a1cd30127cd9