1600873 - Dismiss the measuring tool with the Escape key

Status: ASSIGNED

(DevTools :: Inspector, enhancement, P5)

Description

[Patrick Brosset <:pbro>]

Dismiss the measuring tool with the Escape key.

From: https://twitter.com/bjnagel/status/1201760263612985344

Comment 1

[Bart Nagel]

It's very frustrating to not be able to use the browser again until I click that tiny button in the dev tools again!

Comment 2

[Patrick Brosset <:pbro>]

This might help a bit:

• in the MeasuringTool highlighter file, we'll need to listen for the keypress event to track the Escape key
• once that happens, it should be easy to call this.hide() I guess
• we'll also need to let the front-end know that the tool is now hidden so the toolbar button can be toggled off too. One idea that comes to mind to do this is:
  • send a new event from the MeasuringTool using this.emit("highlighter-event", { type: "hidden-by-esc" }); or something like this. The important bit is that it's a highlighter-event event, because those ones get relayed automatically to the client-side.
  • then on the front-end side, probably in createHighlightButton, we should listen for that specific event and force an update of the button. The command-button-responsive button is a good example as it uses a setup and teardown function pair to listen to events and force onChange updates when they occur. We should do something similar here.

Comment 3

[zer0 [:matteo]]

Thanks for the last part, I the "highlighter-event" special event type was exactly the missing link!
With that info, I should be able to make a working patch – and, I'd like to work on this bug. :)

Comment 4

[zer0 [:matteo]]

Sorry for not updated this bug for a while, but I forget to mention that after the holidays I would leave for my honeymoon :) So, feel free to work on this or re-assign if there is someone interested before I got back!

I'll be able to work again on bugs at the end of January.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hi Matteo!
Are you still interested in fixing this bug?

Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

No activity, unassigning

Honza

Comment 7

[Sebastian Zartner [:sebo]]

Attachment: Bug 1600873 - [devtools] Allowed to dismiss the Measuring Tool via Escape key. r=#devtools-reviewers