1600930 - Work in progress is failing with no arc

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Piotr Zalewa [:zalun]]

moz-phab --no-arc --wip -b 1481539
Submitting 1 commit as Work In Progress:
(D55655) a831e17e849c Bug 1481539 - WIP
Submit to https://phabricator.services.mozilla.com (YES/No/Always)?

Updating revision D55655:
a831e17e849c Bug 1481539 - WIP
Exception when processing transaction of type "plan-changes": Error while reading "value": Expected boolean (true or false), got something else.

It went fine with arc

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1600930 - WIP does not fail with --no-arc

We were encoding a boolean parameter as a string, which was confusing phabricator

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1600930 - adds test for plan-changes value r?zalun

There was an integration issue with the "plan-changes" transaction where we were providing a string value instead of a boolean. This was fixed in a previous commit, but this tests should help ensure that we don't have a regression

Depends on D56027